Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: chrome/browser/prerender/prerender_manager.cc

Issue 525793002: Make WebContentsObserver::web_contents() public (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments addressed Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prerender/prerender_manager.h ('k') | chrome/browser/translate/chrome_translate_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_manager.cc
diff --git a/chrome/browser/prerender/prerender_manager.cc b/chrome/browser/prerender/prerender_manager.cc
index 3627820ad4329d80faf983d13e4a6647300e7aeb..09d35a474b94efad47a4f94a03e8a793ed6b3977 100644
--- a/chrome/browser/prerender/prerender_manager.cc
+++ b/chrome/browser/prerender/prerender_manager.cc
@@ -1068,16 +1068,12 @@ PrerenderManager::PendingSwap::~PendingSwap() {
target_route_id_, swap_successful_);
}
-WebContents* PrerenderManager::PendingSwap::target_contents() const {
- return web_contents();
-}
-
void PrerenderManager::PendingSwap::BeginSwap() {
if (g_hang_session_storage_merges_for_testing)
return;
SessionStorageNamespace* target_namespace =
- target_contents()->GetController().GetDefaultSessionStorageNamespace();
+ web_contents()->GetController().GetDefaultSessionStorageNamespace();
SessionStorageNamespace* prerender_namespace =
prerender_data_->contents()->GetSessionStorageNamespace();
@@ -1198,9 +1194,11 @@ void PrerenderManager::PendingSwap::OnMergeCompleted(
// TODO(davidben): Can we make this less fragile?
PrerenderManager* manager = manager_;
PrerenderData* prerender_data = prerender_data_;
- WebContents* new_web_contents = manager_->SwapInternal(
- GURL(url_), target_contents(), prerender_data_,
- should_replace_current_entry_);
+ WebContents* new_web_contents =
+ manager_->SwapInternal(GURL(url_),
+ web_contents(),
+ prerender_data_,
+ should_replace_current_entry_);
if (!new_web_contents) {
manager->RecordEvent(prerender_data->contents(),
PRERENDER_EVENT_MERGE_RESULT_SWAPIN_FAILED);
@@ -1502,7 +1500,7 @@ PrerenderManager::FindPrerenderDataForTargetContents(
for (ScopedVector<PrerenderData>::iterator it = active_prerenders_.begin();
it != active_prerenders_.end(); ++it) {
if ((*it)->pending_swap() &&
- (*it)->pending_swap()->target_contents() == target_contents)
+ (*it)->pending_swap()->web_contents() == target_contents)
return *it;
}
return NULL;
« no previous file with comments | « chrome/browser/prerender/prerender_manager.h ('k') | chrome/browser/translate/chrome_translate_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698