chrome/browser/extensions/api/web_view/web_view_internal_api.cc - Issue 525793002: Make WebContentsObserver::web_contents() public

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_view/web_view_internal_api.cc

Issue 525793002: Make WebContentsObserver::web_contents() public (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments addressed Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/web_view/web_view_internal_api.cc

diff --git a/chrome/browser/extensions/api/web_view/web_view_internal_api.cc b/chrome/browser/extensions/api/web_view/web_view_internal_api.cc

index 404bc629073899c9544f96e9f0311c397e32e0f5..0343694a5315d467ed163ddd32784503f58b3aa6 100644

--- a/chrome/browser/extensions/api/web_view/web_view_internal_api.cc

+++ b/chrome/browser/extensions/api/web_view/web_view_internal_api.cc

@@ -354,7 +354,7 @@ WebContents* WebViewInternalCaptureVisibleRegionFunction::GetWebContentsForID(

int instance_id) {

WebViewGuest* guest = WebViewGuest::From(

render_view_host()->GetProcess()->GetID(), instance_id);

- return guest ? guest->guest_web_contents() : NULL;

+ return guest ? guest->web_contents() : NULL;

}

void WebViewInternalCaptureVisibleRegionFunction::OnCaptureFailure(

@@ -526,7 +526,7 @@ bool WebViewInternalSetPermissionFunction::RunAsyncSafe(WebViewGuest* guest) {

user_input = *params->user_input;

WebViewPermissionHelper* web_view_permission_helper =

- WebViewPermissionHelper:: FromWebContents(guest->guest_web_contents());

+ WebViewPermissionHelper::FromWebContents(guest->web_contents());

WebViewPermissionHelper::SetPermissionResult result =

web_view_permission_helper->SetPermission(