Make WebContentsObserver::web_contents() public

chrome/browser/devtools/devtools_window.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_
 #define CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_
 
 #include "chrome/browser/devtools/devtools_contents_resizing_strategy.h"
 #include "chrome/browser/devtools/devtools_toggle_action.h"
 #include "chrome/browser/devtools/devtools_ui_bindings.h"
@@ skipping 11 matching lines @@
 class RenderViewHost;
 }
 
 namespace user_prefs {
 class PrefRegistrySyncable;
 }
 
 class DevToolsWindow : public DevToolsUIBindings::Delegate,
                        public content::WebContentsDelegate {
  public:
   class ObserverWithAccessor : public content::WebContentsObserver {

[dgozman, 2014/08/31 08:25:29]

The whole purpose of this class was to expose web_contents(). You can safely
remove it and replace with content::WebContentsOberver.

[lucinka.brozkova, 2014/08/31 16:13:54]

There are two options:

First:
Keeping this class, because it is allowing construction and destruction of
content::WebContentsObserver

Second:
Remove this class and make constructor
content::WebContentsObserver(content::WebContents* web_contents) and destructor
public.

I favour the second option. Before, creating just WebContentsObserver was not
useful, but now it can provide a safe pointer to WebContents. Safe in the sense
that it is NULL if WebContents was destroyed. 

jam@ : What is your opinion about this?

On 2014/08/31 08:25:29, dgozman wrote:

[jam, 2014/09/02 19:43:58]

I don't think we should use a WebContentsObserver as a safe poiner to WCO. If we
really did want to do such a thing, which isn't clear to me, we would make
WebContents vend weak pointers.

[lucinka.brozkova, 2014/09/03 08:16:24]

Acknowledged.

    public:
     explicit ObserverWithAccessor(content::WebContents* web_contents);
     virtual ~ObserverWithAccessor();
-    content::WebContents* GetWebContents();
 
    private:
     DISALLOW_COPY_AND_ASSIGN(ObserverWithAccessor);
   };
 
   static const char kDevToolsApp[];
 
   virtual ~DevToolsWindow();
 
   static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
@@ skipping 266 matching lines @@
   base::Closure close_callback_;
 
   base::TimeTicks inspect_element_start_time_;
   scoped_ptr<DevToolsEventForwarder> event_forwarder_;
 
   friend class DevToolsEventForwarder;
   DISALLOW_COPY_AND_ASSIGN(DevToolsWindow);
 };
 
 #endif  // CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_