Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 525733004: Add description for ServiceWorker.ScriptSize histogram (Closed)

Created:
6 years, 3 months ago by Kunihiko Sakamoto
Modified:
6 years, 3 months ago
Reviewers:
Ilya Sherman, horo
CC:
chromium-reviews, asvitkine+watch_chromium.org, serviceworker-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add description for ServiceWorker.ScriptSize histogram Blink-side change: https://codereview.chromium.org/524553002/ BUG=408451 Committed: https://crrev.com/a476e6133746f35fe3bcca508fd4ddc195b36be7 Cr-Commit-Position: refs/heads/master@{#293058}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : Remove "InKB" suffix #

Total comments: 2

Patch Set 4 : Add units attribute #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Kunihiko Sakamoto
6 years, 3 months ago (2014-09-01 08:34:08 UTC) #2
horo
https://codereview.chromium.org/525733004/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/525733004/diff/1/tools/metrics/histograms/histograms.xml#newcode28650 tools/metrics/histograms/histograms.xml:28650: + script. Add this. "It doesn't include the size ...
6 years, 3 months ago (2014-09-01 09:07:21 UTC) #3
Kunihiko Sakamoto
https://codereview.chromium.org/525733004/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/525733004/diff/1/tools/metrics/histograms/histograms.xml#newcode28650 tools/metrics/histograms/histograms.xml:28650: + script. On 2014/09/01 09:07:21, horo wrote: > Add ...
6 years, 3 months ago (2014-09-01 09:56:12 UTC) #4
horo
lgtm
6 years, 3 months ago (2014-09-01 09:58:36 UTC) #5
Ilya Sherman
LGTM % a suggestion: https://codereview.chromium.org/525733004/diff/40001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/525733004/diff/40001/tools/metrics/histograms/histograms.xml#newcode28646 tools/metrics/histograms/histograms.xml:28646: +<histogram name="ServiceWorker.ScriptSize"> Please add a ...
6 years, 3 months ago (2014-09-03 00:30:01 UTC) #6
Kunihiko Sakamoto
Thanks! https://codereview.chromium.org/525733004/diff/40001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/525733004/diff/40001/tools/metrics/histograms/histograms.xml#newcode28646 tools/metrics/histograms/histograms.xml:28646: +<histogram name="ServiceWorker.ScriptSize"> On 2014/09/03 00:30:00, Ilya Sherman wrote: ...
6 years, 3 months ago (2014-09-03 00:35:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksakamoto@chromium.org/525733004/60001
6 years, 3 months ago (2014-09-03 00:37:32 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 5b9d5e5cfe502a3f1f43959fb17788120b6a43f5
6 years, 3 months ago (2014-09-03 02:41:16 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:23:08 UTC) #11
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/a476e6133746f35fe3bcca508fd4ddc195b36be7
Cr-Commit-Position: refs/heads/master@{#293058}

Powered by Google App Engine
This is Rietveld 408576698