Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 525703002: Fix order or evaluation bug in wifi services code (Closed)

Created:
6 years, 3 months ago by Reid Kleckner
Modified:
6 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix order or evaluation bug in wifi services code R=thakis@chromium.org BUG=409318, 82385 Committed: https://crrev.com/b1394741221e9e21b129d10b654b5a547260af8c Cr-Commit-Position: refs/heads/master@{#292760}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M chrome/browser/extensions/api/networking_private/networking_private_service_client.cc View 4 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Nico
lgtm, nice!
6 years, 3 months ago (2014-08-30 00:55:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rnk@chromium.org/525703002/1
6 years, 3 months ago (2014-08-30 00:56:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as aecf9660e027aa5c29bf8133b2c0728f4e1f9221
6 years, 3 months ago (2014-08-30 02:16:54 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:13:21 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1394741221e9e21b129d10b654b5a547260af8c
Cr-Commit-Position: refs/heads/master@{#292760}

Powered by Google App Engine
This is Rietveld 408576698