Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 525613003: Use swarming on experimental memory trybots (Closed)

Created:
6 years, 3 months ago by Paweł Hajdan Jr.
Modified:
6 years, 2 months ago
Reviewers:
jam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use swarming on experimental memory trybots With this change they take about 1 hour 25 minutes to cycle. Next step is likely swarming net_unittests. BUG=387743 R=jam@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/18112c74cee064411a29cfdc3f3464b653b4a67a

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Total comments: 1

Patch Set 4 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -5 lines) Patch
M testing/buildbot/chromium_memory_trybot.json View 1 2 3 4 chunks +23 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
Paweł Hajdan Jr.
6 years, 2 months ago (2014-09-24 22:11:35 UTC) #2
jam
1) why not just swarm everything at the same time so we can see the ...
6 years, 2 months ago (2014-09-24 22:21:17 UTC) #3
Paweł Hajdan Jr.
On 2014/09/24 22:21:17, jam wrote: > 1) why not just swarm everything at the same ...
6 years, 2 months ago (2014-09-24 22:35:29 UTC) #4
jam
On 2014/09/24 22:35:29, Paweł Hajdan Jr. wrote: > On 2014/09/24 22:21:17, jam wrote: > > ...
6 years, 2 months ago (2014-09-24 22:38:24 UTC) #5
Paweł Hajdan Jr.
Okay, PTAL.
6 years, 2 months ago (2014-09-24 22:46:57 UTC) #6
jam
lgtm, thanks
6 years, 2 months ago (2014-09-24 22:47:38 UTC) #7
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/18112c74cee064411a29cfdc3f3464b653b4a67a Cr-Commit-Position: refs/heads/master@{#296575}
6 years, 2 months ago (2014-09-24 23:49:35 UTC) #8
Paweł Hajdan Jr.
Committed patchset #4 (id:60001) manually as 18112c7 (presubmit successful).
6 years, 2 months ago (2014-09-24 23:49:40 UTC) #9
jam
6 years, 2 months ago (2014-09-24 23:56:18 UTC) #10
Message was sent while issue was closed.
On 2014/09/24 23:49:40, Paweł Hajdan Jr. wrote:
> Committed patchset #4 (id:60001) manually as 18112c7 (presubmit successful).

btw I forgot to add that content's tests are already swarmed, so that's an easy
thing to turn on. should save about 8 minutes and bring the bot very close to 40
minutes :)

Powered by Google App Engine
This is Rietveld 408576698