Subzero: Remove the need for a separate NaCl SDK.

Subzero: Remove the need for a separate NaCl SDK installation.

Now it assumes tests are being run from within the Subzero portion of the native_client tree, and sets up PATH to find PNaCl tools relative to there.

It may be necessary to do a one-time setup to be able to build pexes:

    pnacl/build.sh sdk newlib

or the equivalent scons commands.

If the tool chain is updated, propagate the changes via:

    toolchain_build/toolchain_build_pnacl.py llvm_i686_linux --install=toolchain/linux_x86/pnacl_newlib

BUG= none
R=jvoung@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=16178a1

[Jim Stichnoth, 2014-08-29 23:35:16]

stichnot@chromium.org changed reviewers:
+ dschuff@chromium.org, jvoung@chromium.org, kschimpf@google.com

[Jim Stichnoth, 2014-08-29 23:39:04]

BTW, the lit.cfg change is something that I think should have been part of
Karl's recent bitcode reader commit, so that lit can find llvm-as.

[jvoung (off chromium), 2014-09-02 16:59:47]

For the commit message, I think the "TOOLCHAIN_LABEL=pnacl_linux_x86" part is
obsolete. The toolchain directory was renamed again.

https://codereview.chromium.org/525603002/diff/20001/pydir/build-pnacl-ir.py
File pydir/build-pnacl-ir.py (right):

https://codereview.chromium.org/525603002/diff/20001/pydir/build-pnacl-ir.py#...
pydir/build-pnacl-ir.py:35: shellcmd('opt -pnacl-abi-simplify-preopt
-pnacl-abi-simplify-postopt' +
You might be able to just invoke 'pnacl-opt'  and then there won't be a need to
have host_x86_32/bin in the path.

[Jim Stichnoth, 2014-09-02 18:30:00]

On 2014/09/02 16:59:47, jvoung wrote:
> For the commit message, I think the "TOOLCHAIN_LABEL=pnacl_linux_x86" part is
> obsolete. The toolchain directory was renamed again.

Thanks, it does look like the TOOLCHAIN_LABEL part was unnecessary.

[Jim Stichnoth, 2014-09-02 18:30:34]

I also fixed some of the PATH issues by finding the base native_client directory
relative to cwd.

https://codereview.chromium.org/525603002/diff/20001/pydir/build-pnacl-ir.py
File pydir/build-pnacl-ir.py (right):

https://codereview.chromium.org/525603002/diff/20001/pydir/build-pnacl-ir.py#...
pydir/build-pnacl-ir.py:35: shellcmd('opt -pnacl-abi-simplify-preopt
-pnacl-abi-simplify-postopt' +
On 2014/09/02 16:59:47, jvoung wrote:
> You might be able to just invoke 'pnacl-opt'  and then there won't be a need
to
> have host_x86_32/bin in the path.

Good point, done.  FWIW, crosstest.py was already adding host_x86_32/bin to the
path.

[jvoung (off chromium), 2014-09-02 20:54:11]

LGTM

[Jim Stichnoth, 2014-09-02 21:12:12]

Committed patchset #3 (id:40001) manually as 16178a1 (presubmit successful).