Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Unified Diff: content/browser/frame_host/render_frame_host_manager_unittest.cc

Issue 525583002: Fix RenderFrameHost lifetime and clean up CommitPending. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clean up Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_manager_unittest.cc
diff --git a/content/browser/frame_host/render_frame_host_manager_unittest.cc b/content/browser/frame_host/render_frame_host_manager_unittest.cc
index 23b49c8cde575de2dec6b95bc533236b58a864e0..c9124e6b49c74824d5f1063dbefadf67a081bd96 100644
--- a/content/browser/frame_host/render_frame_host_manager_unittest.cc
+++ b/content/browser/frame_host/render_frame_host_manager_unittest.cc
@@ -311,13 +311,13 @@ class RenderFrameHostManagerTest
// Make sure that we start to run the unload handler at the time of commit.
bool expecting_rfh_shutdown = false;
if (old_rfh != active_rfh && !rfh_observer.deleted()) {
+ EXPECT_EQ(RenderFrameHostImpl::STATE_PENDING_SWAP_OUT,
+ old_rfh->rfh_state());
if (!old_rfh->GetSiteInstance()->active_frame_count()) {
expecting_rfh_shutdown = true;
- EXPECT_EQ(RenderFrameHostImpl::STATE_PENDING_SHUTDOWN,
- old_rfh->rfh_state());
- } else {
- EXPECT_EQ(RenderFrameHostImpl::STATE_PENDING_SWAP_OUT,
- old_rfh->rfh_state());
+ EXPECT_TRUE(
+ old_rfh->frame_tree_node()->render_manager()->IsPendingDeletion(
+ old_rfh));
}
}
@@ -1603,7 +1603,9 @@ TEST_F(RenderFrameHostManagerTest, DeleteFrameAfterSwapOutACK) {
EXPECT_EQ(rfh2, contents()->GetMainFrame());
EXPECT_TRUE(contents()->GetPendingMainFrame() == NULL);
EXPECT_EQ(RenderFrameHostImpl::STATE_DEFAULT, rfh2->rfh_state());
- EXPECT_EQ(RenderFrameHostImpl::STATE_PENDING_SHUTDOWN, rfh1->rfh_state());
+ EXPECT_EQ(RenderFrameHostImpl::STATE_PENDING_SWAP_OUT, rfh1->rfh_state());
+ EXPECT_TRUE(
+ rfh1->frame_tree_node()->render_manager()->IsPendingDeletion(rfh1));
// Simulate the swap out ack.
rfh1->OnSwappedOut();

Powered by Google App Engine
This is Rietveld 408576698