Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: media/BUILD.gn

Issue 525533003: Add content_shell_test_apk and a several dependencies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-content-shell-apk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/android/BUILD.gn ('k') | media/base/android/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/BUILD.gn
diff --git a/media/BUILD.gn b/media/BUILD.gn
index e548b5dc64e3a5d5baa37874aec2e417f3e60fc1..0668a22ff4f0c3f76737b1c84e38f590fb98c968 100644
--- a/media/BUILD.gn
+++ b/media/BUILD.gn
@@ -298,7 +298,7 @@ component("media") {
"//media/base/android:video_capture_jni_headers",
]
if (!is_android_webview_build) {
- deps += [ ":media_java" ]
+ deps += [ "//media/base/android:media_java" ]
}
}
@@ -477,7 +477,30 @@ test("media_unittests") {
"formats/webm/webm_webvtt_parser_unittest.cc",
]
- if (!is_android) {
+ deps = [
+ ":media",
+ ":test_support",
+ "//base/allocator",
+ "//base/test:test_support",
+ "//media/audio:unittests",
+ "//media/audio:test_support",
+ "//media/base:unittests",
+ "//media/base:test_support",
+ "//skia", # Direct dependency required to inherit config.
+ "//testing/gmock",
+ "//testing/gtest",
+ "//third_party/widevine/cdm:version_h",
+ "//ui/gfx:test_support",
+ "//url",
+ ]
+
+ if (is_android) {
+ deps += [
+ "//media/base/android",
+ # TODO(GYP)
+ #"//testing/android:native_test_native_code"
+ ]
+ } else {
sources += [
"ffmpeg/ffmpeg_common_unittest.cc",
"filters/audio_decoder_unittest.cc",
@@ -490,12 +513,6 @@ test("media_unittests") {
"filters/pipeline_integration_test.cc",
"filters/pipeline_integration_test_base.cc",
]
- } else {
-# TODO(ajwong): Blocked on android.
-# deps += [
-# ":player_android",
-# "//testing/android:native_test_native_code"
-# ]
}
if (cpu_arch != "arm" && is_chromeos && use_x11) {
@@ -546,32 +563,6 @@ test("media_unittests") {
configs += [ ":media_config" ]
-# TODO(ajwong): This was in the original gyp, but it seems silly.
-# ['os_posix==1 and OS!="mac"', {
-# 'conditions': [
-# ['use_allocator!="none"', {
-# 'dependencies': [
-# '../base/allocator/allocator.gyp:allocator',
-# ],
-# }],
-# ],
-# }],
- deps = [
- ":media",
- ":test_support",
- "//base/test:test_support",
- "//media/audio:unittests",
- "//media/audio:test_support",
- "//media/base:unittests",
- "//media/base:test_support",
- "//skia", # Direct dependency required to inherit config.
- "//testing/gmock",
- "//testing/gtest",
- # TODO(dalecurtis): Port the rest of Widevine stuff.
- "//third_party/widevine/cdm:version_h",
- "//ui/gfx:test_support",
- "//url",
- ]
if (media_use_ffmpeg) {
deps += [
"//third_party/ffmpeg", # Direct dependency required to inherit config.
@@ -727,23 +718,3 @@ if (use_x11) {
]
}
}
-
-if (is_android) {
- import("//build/config/android/rules.gni")
- android_library("media_java") {
- srcjar_deps = [
- ":media_android_imageformat_list",
- ]
- java_files = []
- }
-
- java_cpp_template("media_android_imageformat_list") {
- sources = [
- "base/android/java/src/org/chromium/media/ImageFormat.template",
- ]
- inputs = [
- "video/capture/android/imageformat_list.h"
- ]
- package_name = "org/chromium/media"
- }
-}
« no previous file with comments | « content/shell/android/BUILD.gn ('k') | media/base/android/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698