Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: build/android/gyp/apk_obfuscate.py

Issue 525533003: Add content_shell_test_apk and a several dependencies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-content-shell-apk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/base.gyp ('k') | build/android/gyp/create_dist_jar.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/apk_obfuscate.py
diff --git a/build/android/gyp/apk_obfuscate.py b/build/android/gyp/apk_obfuscate.py
index b9762cf736d7740a47cc815c04cb38f0083e03dc..fec70c8d0a539a21a187377cb81002e5a37292a1 100755
--- a/build/android/gyp/apk_obfuscate.py
+++ b/build/android/gyp/apk_obfuscate.py
@@ -10,11 +10,9 @@ If proguard is not enabled or 'Release' is not in the configuration name,
obfuscation will be a no-op.
"""
-import fnmatch
import optparse
import os
import sys
-import zipfile
from util import build_utils
@@ -86,19 +84,9 @@ def main(argv):
dependency_class_filters = [
'*R.class', '*R$*.class', '*Manifest.class', '*BuildConfig.class']
- def DependencyClassFilter(name):
- for name_filter in dependency_class_filters:
- if fnmatch.fnmatch(name, name_filter):
- return False
- return True
-
if options.testapp:
- with zipfile.ZipFile(options.test_jar_path, 'w') as test_jar:
- for jar in input_jars:
- with zipfile.ZipFile(jar, 'r') as jar_zip:
- for name in filter(DependencyClassFilter, jar_zip.namelist()):
- with jar_zip.open(name) as zip_entry:
- test_jar.writestr(name, zip_entry.read())
+ build_utils.MergeZips(
+ options.test_jar_path, input_jars, dependency_class_filters)
if options.configuration_name == 'Release' and options.proguard_enabled:
proguard_cmd = [
« no previous file with comments | « base/base.gyp ('k') | build/android/gyp/create_dist_jar.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698