Add content_shell_test_apk and a several dependencies

Add content_shell_test_apk and several dependencies

This adds support for android_apk targets without any java included
directly in the target (only included through deps).

This adds the following targets:

//base:base_javatests
//content/public/android:content_javatests
//content/shell/android:content_shell_test_apk
//media/android:media_android_imageformat_list (moved)
//media/android:media_java (moved+fixed)


BUG=359249
Committed: https://crrev.com/394dfd1052e53e64083daef7cc66055557256dcb
Cr-Commit-Position: refs/heads/master@{#293897}

[cjhopman, 2014-09-06 02:08:27]

cjhopman@chromium.org changed reviewers:
+ newt@chromium.org

[cjhopman, 2014-09-06 02:08:27]

newt: *

[newt (away), 2014-09-08 20:27:30]

a few nits, then lgtm

https://codereview.chromium.org/525533003/diff/60001/build/android/gyp/create...
File build/android/gyp/create_dist_jar.py (right):

https://codereview.chromium.org/525533003/diff/60001/build/android/gyp/create...
build/android/gyp/create_dist_jar.py:20: options, _ = parser.parse_args(args)
use build_utils.CheckOptions() to ensure --output and --inputs were provided?

https://codereview.chromium.org/525533003/diff/60001/build/android/gyp/util/b...
File build/android/gyp/util/build_utils.py (right):

https://codereview.chromium.org/525533003/diff/60001/build/android/gyp/util/b...
build/android/gyp/util/build_utils.py:248: with in_zip.open(name) as zip_entry:
can't you just do:

    out_zip.writestr(name, in_zip.read(name))

and drop the extra "with" statement?

https://codereview.chromium.org/525533003/diff/60001/media/BUILD.gn
File media/BUILD.gn (right):

https://codereview.chromium.org/525533003/diff/60001/media/BUILD.gn#newcode567
media/BUILD.gn:567: # TODO(ajwong): This was in the original gyp, but it seems
silly.
move this comment along with the deps list?

[cjhopman, 2014-09-08 23:02:18]

https://codereview.chromium.org/525533003/diff/60001/build/android/gyp/create...
File build/android/gyp/create_dist_jar.py (right):

https://codereview.chromium.org/525533003/diff/60001/build/android/gyp/create...
build/android/gyp/create_dist_jar.py:20: options, _ = parser.parse_args(args)
On 2014/09/08 20:27:30, newt wrote:
> use build_utils.CheckOptions() to ensure --output and --inputs were provided?

Done.

https://codereview.chromium.org/525533003/diff/60001/build/android/gyp/util/b...
File build/android/gyp/util/build_utils.py (right):

https://codereview.chromium.org/525533003/diff/60001/build/android/gyp/util/b...
build/android/gyp/util/build_utils.py:248: with in_zip.open(name) as zip_entry:
On 2014/09/08 20:27:30, newt wrote:
> can't you just do:
> 
>     out_zip.writestr(name, in_zip.read(name))
> 
> and drop the extra "with" statement?

Done.

https://codereview.chromium.org/525533003/diff/60001/media/BUILD.gn
File media/BUILD.gn (right):

https://codereview.chromium.org/525533003/diff/60001/media/BUILD.gn#newcode567
media/BUILD.gn:567: # TODO(ajwong): This was in the original gyp, but it seems
silly.
On 2014/09/08 20:27:30, newt wrote:
> move this comment along with the deps list?

Done.

[cjhopman, 2014-09-08 23:27:25]

cjhopman@chromium.org changed reviewers:
+ brettw@chromium.org

[cjhopman, 2014-09-08 23:27:26]

brettw: for OWNERS of gn things

[brettw, 2014-09-08 23:35:23]

lgtm

https://codereview.chromium.org/525533003/diff/80001/build/config/android/rul...
File build/config/android/rules.gni (right):

https://codereview.chromium.org/525533003/diff/80001/build/config/android/rul...
build/config/android/rules.gni:722: final_deps += [":${_template_name}__java"]
spaces inside []

https://codereview.chromium.org/525533003/diff/80001/content/shell/android/BU...
File content/shell/android/BUILD.gn (right):

https://codereview.chromium.org/525533003/diff/80001/content/shell/android/BU...
content/shell/android/BUILD.gn:55: 
Extra blank

https://codereview.chromium.org/525533003/diff/80001/media/BUILD.gn
File media/BUILD.gn (right):

https://codereview.chromium.org/525533003/diff/80001/media/BUILD.gn#newcode491
media/BUILD.gn:491: # TODO(dalecurtis): Port the rest of Widevine stuff.
I think you can remove this comment (this matches the gyp build as far as I can
tell).

https://codereview.chromium.org/525533003/diff/80001/media/BUILD.gn#newcode496
media/BUILD.gn:496: # TODO(ajwong): This was in the original gyp, but it seems
silly.
Can you delete this comment and just add "//base/allocator" to the deps.

https://codereview.chromium.org/525533003/diff/80001/media/BUILD.gn#newcode507
media/BUILD.gn:507: if (!is_android) {
Would you mind switching this, so it says if (is_android) { below code } else {
above code }. I think that's much more readable.

https://codereview.chromium.org/525533003/diff/80001/media/BUILD.gn#newcode524
media/BUILD.gn:524: #"//testing/android:native_test_native_code"
Should this have a TODO(GYP)?

[cjhopman, 2014-09-09 00:25:30]

cjhopman@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[cjhopman, 2014-09-09 00:25:31]

dalecurtis@ for media/ OWNERS

[cjhopman, 2014-09-09 00:26:18]

https://codereview.chromium.org/525533003/diff/80001/build/config/android/rul...
File build/config/android/rules.gni (right):

https://codereview.chromium.org/525533003/diff/80001/build/config/android/rul...
build/config/android/rules.gni:722: final_deps += [":${_template_name}__java"]
On 2014/09/08 23:35:22, brettw wrote:
> spaces inside []

Done.

https://codereview.chromium.org/525533003/diff/80001/content/shell/android/BU...
File content/shell/android/BUILD.gn (right):

https://codereview.chromium.org/525533003/diff/80001/content/shell/android/BU...
content/shell/android/BUILD.gn:55: 
On 2014/09/08 23:35:22, brettw wrote:
> Extra blank

Done.

https://codereview.chromium.org/525533003/diff/80001/media/BUILD.gn
File media/BUILD.gn (right):

https://codereview.chromium.org/525533003/diff/80001/media/BUILD.gn#newcode491
media/BUILD.gn:491: # TODO(dalecurtis): Port the rest of Widevine stuff.
On 2014/09/08 23:35:23, brettw wrote:
> I think you can remove this comment (this matches the gyp build as far as I
can
> tell).

Done.

https://codereview.chromium.org/525533003/diff/80001/media/BUILD.gn#newcode496
media/BUILD.gn:496: # TODO(ajwong): This was in the original gyp, but it seems
silly.
On 2014/09/08 23:35:23, brettw wrote:
> Can you delete this comment and just add "//base/allocator" to the deps.

Done.

https://codereview.chromium.org/525533003/diff/80001/media/BUILD.gn#newcode507
media/BUILD.gn:507: if (!is_android) {
On 2014/09/08 23:35:22, brettw wrote:
> Would you mind switching this, so it says if (is_android) { below code } else
{
> above code }. I think that's much more readable.

Done.

https://codereview.chromium.org/525533003/diff/80001/media/BUILD.gn#newcode524
media/BUILD.gn:524: #"//testing/android:native_test_native_code"
On 2014/09/08 23:35:22, brettw wrote:
> Should this have a TODO(GYP)?

Done.

[DaleCurtis, 2014-09-09 00:35:44]

lgtm

[cjhopman, 2014-09-09 00:59:14]

The CQ bit was checked by cjhopman@chromium.org

[commit-bot: I haz the power, 2014-09-09 01:09:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/cjhopman@chromium.org/525533003/100001

[commit-bot: I haz the power, 2014-09-09 08:56:52]

Committed patchset #6 (id:100001) as bc1a22803bd08a25fde4d78ec380a92077ffc20b

[commit-bot: I haz the power, 2014-09-10 03:52:02]

Patchset 6 (id:??) landed as
https://crrev.com/394dfd1052e53e64083daef7cc66055557256dcb
Cr-Commit-Position: refs/heads/master@{#293897}