Eliminate the CALENDAR_PICKER compile time flag as only android uses this flag and the web facing p…

Eliminate the CALENDAR_PICKER compile time flag as only android uses this flag and the web facing pieces that use this are already hidden behind a different compile time flag: ENABLE_INPUT_MULTIPLE_FIELDS_UI

BUG=none

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161353

[atreat, 2013-11-04 21:41:11]

ch.dumez@samsung.com: Please review changes in 

eseidel@chromium.org: Please review changes in 

abarth@chromium.org: Please review changes in 

On a mission to eliminate the last of the compile time flags.  I was going to
convert this to a runtime flag, but all the web facing bits are hidden behind
another compile time flag from what I can tell.

[Inactive, 2013-11-05 00:50:01]

The win try bot failure looks legit.

[abarth-chromium, 2013-11-05 06:49:46]

This is hidden behind page popup, is that the idea?  Looks like you're on the
right track.

[atreat, 2013-11-05 16:02:30]

On 2013/11/05 06:49:46, abarth wrote:
> This is hidden behind page popup, is that the idea?  Looks like you're on the
> right track.

Exactly.  Passing all trybots now.

[abarth-chromium, 2013-11-05 16:06:28]

LGTM

[commit-bot: I haz the power, 2013-11-05 16:13:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/adam.treat@samsung.com/52553008/70001

[commit-bot: I haz the power, 2013-11-05 17:18:52]

Change committed as 161353

[tkent, 2013-11-05 21:09:19]

https://codereview.chromium.org/52553008/diff/70001/Source/web/web.gyp
File Source/web/web.gyp (left):

https://codereview.chromium.org/52553008/diff/70001/Source/web/web.gyp#oldcod...
Source/web/web.gyp:323: '--condition=ENABLE(CALENDAR_PICKER)',
This change increase Android binary size needlessly, right?

[tkent, 2013-11-05 21:13:27]

> BUG=none

We have it. crbug.com/243717.

[tkent, 2013-11-05 22:38:11]

+peter

[Peter Beverloo, 2013-11-06 14:36:08]

Generally it's appreciated to include binary size information when removing
flags like this, since that's something we (and others) care about on Android. 
I've compiled Content Shell with and without your patch.  The size increase is
negligible for a debug build, so it'll be very close to zero on a release build.


Size without this patch applied (in debug mode):

ContentShell.apk - 27057219 bytes
libcontent_shell_content_view.so - 2064785112 bytes

With this patch applied (in debug mode):

ContentShell.apk - 27057990 bytes (+771 bytes, +0%)
libcontent_shell_content_view.so - 2064907112 bytes (+122,000 bytes, +0%)