Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: content/common/view_messages.h

Issue 525523003: Remove two unnecessary params in ViewHostMsg_UpdateRect_Params (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Android build Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // IPC messages for page rendering. 5 // IPC messages for page rendering.
6 // Multiply-included message file, hence no include guard. 6 // Multiply-included message file, hence no include guard.
7 7
8 #include "base/memory/shared_memory.h" 8 #include "base/memory/shared_memory.h"
9 #include "base/process/process.h" 9 #include "base/process/process.h"
10 #include "base/strings/string16.h" 10 #include "base/strings/string16.h"
(...skipping 356 matching lines...) Expand 10 before | Expand all | Expand 10 after
367 // Whether or not the IME should be shown as a result of this update. Even if 367 // Whether or not the IME should be shown as a result of this update. Even if
368 // true, the IME will only be shown if the type is appropriate (e.g. not 368 // true, the IME will only be shown if the type is appropriate (e.g. not
369 // TEXT_INPUT_TYPE_NONE). 369 // TEXT_INPUT_TYPE_NONE).
370 IPC_STRUCT_MEMBER(bool, show_ime_if_needed) 370 IPC_STRUCT_MEMBER(bool, show_ime_if_needed)
371 371
372 // Whether this change is originated from non-IME (e.g. Javascript, Autofill). 372 // Whether this change is originated from non-IME (e.g. Javascript, Autofill).
373 IPC_STRUCT_MEMBER(bool, is_non_ime_change) 373 IPC_STRUCT_MEMBER(bool, is_non_ime_change)
374 IPC_STRUCT_END() 374 IPC_STRUCT_END()
375 375
376 IPC_STRUCT_BEGIN(ViewHostMsg_UpdateRect_Params) 376 IPC_STRUCT_BEGIN(ViewHostMsg_UpdateRect_Params)
377 // The scroll offset of the render view.
378 IPC_STRUCT_MEMBER(gfx::Vector2d, scroll_offset)
379
380 // The size of the RenderView when this message was generated. This is 377 // The size of the RenderView when this message was generated. This is
381 // included so the host knows how large the view is from the perspective of 378 // included so the host knows how large the view is from the perspective of
382 // the renderer process. This is necessary in case a resize operation is in 379 // the renderer process. This is necessary in case a resize operation is in
383 // progress. If auto-resize is enabled, this should update the corresponding 380 // progress. If auto-resize is enabled, this should update the corresponding
384 // view size. 381 // view size.
385 IPC_STRUCT_MEMBER(gfx::Size, view_size) 382 IPC_STRUCT_MEMBER(gfx::Size, view_size)
386 383
387 // New window locations for plugin child windows. 384 // New window locations for plugin child windows.
388 IPC_STRUCT_MEMBER(std::vector<content::WebPluginGeometry>, 385 IPC_STRUCT_MEMBER(std::vector<content::WebPluginGeometry>,
389 plugin_window_moves) 386 plugin_window_moves)
390 387
391 // The following describes the various bits that may be set in flags: 388 // The following describes the various bits that may be set in flags:
392 // 389 //
393 // ViewHostMsg_UpdateRect_Flags::IS_RESIZE_ACK 390 // ViewHostMsg_UpdateRect_Flags::IS_RESIZE_ACK
394 // Indicates that this is a response to a ViewMsg_Resize message. 391 // Indicates that this is a response to a ViewMsg_Resize message.
395 // 392 //
396 // ViewHostMsg_UpdateRect_Flags::IS_REPAINT_ACK 393 // ViewHostMsg_UpdateRect_Flags::IS_REPAINT_ACK
397 // Indicates that this is a response to a ViewMsg_Repaint message. 394 // Indicates that this is a response to a ViewMsg_Repaint message.
398 // 395 //
399 // If flags is zero, then this message corresponds to an unsolicited paint 396 // If flags is zero, then this message corresponds to an unsolicited paint
400 // request by the render view. Any of the above bits may be set in flags, 397 // request by the render view. Any of the above bits may be set in flags,
401 // which would indicate that this paint message is an ACK for multiple 398 // which would indicate that this paint message is an ACK for multiple
402 // request messages. 399 // request messages.
403 IPC_STRUCT_MEMBER(int, flags) 400 IPC_STRUCT_MEMBER(int, flags)
404
405 // All the above coordinates are in DIP. This is the scale factor needed
406 // to convert them to pixels.
407 IPC_STRUCT_MEMBER(float, scale_factor)
408 IPC_STRUCT_END() 401 IPC_STRUCT_END()
409 402
410 IPC_STRUCT_BEGIN(ViewMsg_New_Params) 403 IPC_STRUCT_BEGIN(ViewMsg_New_Params)
411 // Renderer-wide preferences. 404 // Renderer-wide preferences.
412 IPC_STRUCT_MEMBER(content::RendererPreferences, renderer_preferences) 405 IPC_STRUCT_MEMBER(content::RendererPreferences, renderer_preferences)
413 406
414 // Preferences for this view. 407 // Preferences for this view.
415 IPC_STRUCT_MEMBER(content::WebPreferences, web_preferences) 408 IPC_STRUCT_MEMBER(content::WebPreferences, web_preferences)
416 409
417 // The ID of the view to be created. 410 // The ID of the view to be created.
(...skipping 1207 matching lines...) Expand 10 before | Expand all | Expand 10 after
1625 // Since the browser keeps handles to the allocated transport DIBs, this 1618 // Since the browser keeps handles to the allocated transport DIBs, this
1626 // message is sent to tell the browser that it may release them when the 1619 // message is sent to tell the browser that it may release them when the
1627 // renderer is finished with them. 1620 // renderer is finished with them.
1628 IPC_MESSAGE_CONTROL1(ViewHostMsg_FreeTransportDIB, 1621 IPC_MESSAGE_CONTROL1(ViewHostMsg_FreeTransportDIB,
1629 TransportDIB::Id /* DIB id */) 1622 TransportDIB::Id /* DIB id */)
1630 #endif 1623 #endif
1631 1624
1632 // Adding a new message? Stick to the sort order above: first platform 1625 // Adding a new message? Stick to the sort order above: first platform
1633 // independent ViewMsg, then ifdefs for platform specific ViewMsg, then platform 1626 // independent ViewMsg, then ifdefs for platform specific ViewMsg, then platform
1634 // independent ViewHostMsg, then ifdefs for platform specific ViewHostMsg. 1627 // independent ViewHostMsg, then ifdefs for platform specific ViewHostMsg.
OLDNEW
« no previous file with comments | « content/common/browser_plugin/browser_plugin_messages.h ('k') | content/public/browser/render_widget_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698