Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 525493003: New pages added to smoothness.key_mobile_sites (Closed)

Created:
6 years, 3 months ago by picksi1
Modified:
5 years, 6 months ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

New pages added to smoothness.key_mobile_sites.py BUG=391005 Committed: https://crrev.com/b66e3a154bd556cbce92fe58496001039bb8185d Cr-Commit-Position: refs/heads/master@{#292879}

Patch Set 1 #

Patch Set 2 : Record_wpr re-run for ESPN to fix flaky tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M tools/perf/page_sets/data/key_mobile_sites.json View 1 1 chunk +10 lines, -3 lines 0 comments Download
A tools/perf/page_sets/data/key_mobile_sites_007.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/key_mobile_sites_008.wpr.sha1 View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/key_mobile_sites.py View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 14 (4 generated)
picksi1
Added 3 new 'bad' pages to key_mobile_sites. This replaces Issue 3722243003 which was adding these ...
6 years, 3 months ago (2014-09-01 14:36:55 UTC) #2
Sami
lgtm, thanks!
6 years, 3 months ago (2014-09-01 14:56:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/picksi@chromium.org/525493003/1
6 years, 3 months ago (2014-09-01 15:04:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 65937414fa2d000ef547d35d791b451253b0e446
6 years, 3 months ago (2014-09-01 16:06:36 UTC) #6
picksi1
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/530813002/ by picksi@chromium.org. ...
6 years, 3 months ago (2014-09-01 16:34:36 UTC) #7
picksi1
I didn't revert this in the end - ironically it wouldn't let me without a ...
6 years, 3 months ago (2014-09-01 16:54:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/picksi@chromium.org/525493003/20001
6 years, 3 months ago (2014-09-08 12:47:32 UTC) #10
picksi1
It looks like the data recorded by the original record_wpr missed out on some non-deterministic ...
6 years, 3 months ago (2014-09-08 12:49:04 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/63857) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/52833) android_arm64_dbg_recipe ...
6 years, 3 months ago (2014-09-08 12:50:24 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:17:05 UTC) #14
Patchset 2 (id:??) landed as
https://crrev.com/b66e3a154bd556cbce92fe58496001039bb8185d
Cr-Commit-Position: refs/heads/master@{#292879}

Powered by Google App Engine
This is Rietveld 408576698