Issue 525433002: When ignoring color input don't use vertex attribs on gpu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 525433002: When ignoring color input don't use vertex attribs on gpu (Closed)

Created:
6 years, 3 months ago by egdaniel

Modified:
6 years, 3 months ago

Reviewers:
bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

When ignoring color input don't use vertex attribs on gpu Also rename SolidWhite_ColorInput enum to be AllOnes_ColorInput to better reflect what it's use is BUG=skia: Committed: https://skia.googlesource.com/skia/+/842b086a3c876061e1279d47e6009629c9818b03

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -5 lines)			Patch
M	src/gpu/gl/GrGLProgram.cpp	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
M	src/gpu/gl/GrGLProgramDesc.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/gl/GrGLProgramDesc.cpp	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/gpu/gl/builders/GrGLProgramBuilder.cpp	View		2 chunks	+3 lines, -1 line	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/525433002/20001

6 years, 3 months ago (2014-09-02 16:54:32 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-02 17:01:36 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as 842b086a3c876061e1279d47e6009629c9818b03