Issue 525393002: Clean up code duplication of isAtShadowBoundary()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 525393002: Clean up code duplication of isAtShadowBoundary() (Closed)

Created:
6 years, 3 months ago by rtakacs

Modified:
6 years, 3 months ago

Reviewers:
rune, eseidel

CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, ed+blinkwatch_opera.com, rwlbuis, rune+blink, sof

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Clean up code duplication of isAtShadowBoundary() Moved isAtShadowBoundary() to Element.h in order to remove duplication. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181201

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -21 lines)			Patch
M	Source/core/css/resolver/StyleAdjuster.cpp	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	Source/core/css/resolver/StyleResolver.cpp	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	Source/core/dom/Element.h	View	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtakacs.u-szeged@partner.samsung.com/525393002/1

6 years, 3 months ago (2014-09-01 20:16:11 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-01 20:58:02 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 181201

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages