Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Unified Diff: mojo/android/javatests/src/org/chromium/mojo/bindings/ConnectorTest.java

Issue 525383002: MessageReceiver must handle Message and not MessageWithHeader. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Follow review Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/android/javatests/src/org/chromium/mojo/bindings/ConnectorTest.java
diff --git a/mojo/android/javatests/src/org/chromium/mojo/bindings/ConnectorTest.java b/mojo/android/javatests/src/org/chromium/mojo/bindings/ConnectorTest.java
index 09871ca42cf1d2b0e2aa6f709b8af36569719880..d6e0489be51d2ffdcb79e037d6cfac6c37c1b380 100644
--- a/mojo/android/javatests/src/org/chromium/mojo/bindings/ConnectorTest.java
+++ b/mojo/android/javatests/src/org/chromium/mojo/bindings/ConnectorTest.java
@@ -30,7 +30,7 @@ public class ConnectorTest extends MojoTestCase {
private MessagePipeHandle mHandle;
private Connector mConnector;
- private MessageWithHeader mTestMessage;
+ private Message mTestMessage;
private RecordingMessageReceiver mReceiver;
private CapturingErrorHandler mErrorHandler;
@@ -77,7 +77,7 @@ public class ConnectorTest extends MojoTestCase {
MessagePipeHandle.ReadFlags.NONE);
assertEquals(MojoResult.OK, result.getMojoResult());
assertEquals(DATA_LENGTH, result.getMessageSize());
- assertEquals(mTestMessage.getMessage().buffer, received);
+ assertEquals(mTestMessage.getData(), received);
}
/**
@@ -85,14 +85,14 @@ public class ConnectorTest extends MojoTestCase {
*/
@SmallTest
public void testReceivingMessage() {
- mHandle.writeMessage(mTestMessage.getMessage().buffer, new ArrayList<Handle>(),
+ mHandle.writeMessage(mTestMessage.getData(), new ArrayList<Handle>(),
MessagePipeHandle.WriteFlags.NONE);
nativeRunLoop(RUN_LOOP_TIMEOUT_MS);
assertNull(mErrorHandler.getLastMojoException());
assertEquals(1, mReceiver.messages.size());
- MessageWithHeader received = mReceiver.messages.get(0);
- assertEquals(0, received.getMessage().handles.size());
- assertEquals(mTestMessage.getMessage().buffer, received.getMessage().buffer);
+ Message received = mReceiver.messages.get(0);
+ assertEquals(0, received.getHandles().size());
+ assertEquals(mTestMessage.getData(), received.getData());
}
/**

Powered by Google App Engine
This is Rietveld 408576698