Chromium Code Reviews| Index: Source/devtools/front_end/documentation/DocumentationView.js |
| diff --git a/Source/devtools/front_end/documentation/DocumentationView.js b/Source/devtools/front_end/documentation/DocumentationView.js |
| index 5e782965a5ae9b94703114a957809ef2cd9a23cc..84e091d5f7a7e6f8222782b1f8bf837079dfdb85 100644 |
| --- a/Source/devtools/front_end/documentation/DocumentationView.js |
| +++ b/Source/devtools/front_end/documentation/DocumentationView.js |
| @@ -22,6 +22,7 @@ WebInspector.DocumentationView.showDocumentationURL = function(url, searchItem) |
| if (!WebInspector.DocumentationView._view) |
| WebInspector.DocumentationView._view = new WebInspector.DocumentationView(); |
| var view = WebInspector.DocumentationView._view; |
| + view.element.removeChildren(); |
|
lushnikov
2014/09/04 12:51:37
this looks like a left-over from a rebaseline, it
semeny
2014/09/04 16:17:20
Done.
|
| WebInspector.inspectorView.showCloseableViewInDrawer("documentation", WebInspector.UIString("Documentation"), view); |
| view.showDocumentation(url, searchItem); |
| } |
| @@ -104,6 +105,22 @@ WebInspector.DocumentationView.Renderer.prototype = { |
| this._createTextSectionWithTitle("Remarks", this._article.remarks); |
| return this._element; |
| + |
| + /** |
| + * @param {string} name |
| + * @return {boolean} |
| + */ |
| + function isMethod(name) |
|
lushnikov
2014/09/04 12:51:37
where do you use this method?
lushnikov
2014/09/04 12:51:37
wrong indent (9 chars?)
semeny
2014/09/04 16:17:20
Done.
|
| + { |
| + var tokens = name.split("."); |
| + var currentObject = window; |
| + for (var i = 0; i < tokens.length; i++) { |
|
lushnikov
2014/09/04 12:51:37
++i
semeny
2014/09/04 16:17:20
Done.
|
| + currentObject = currentObject[tokens[i]]; |
| + if (!currentObject) |
| + return false; |
| + } |
| + return (typeof(currentObject) === "function"); |
|
lushnikov
2014/09/04 12:51:37
typeof is operator - no need for brackets
semeny
2014/09/04 16:17:20
Done.
|
| + } |
| }, |
| /** |
| @@ -292,12 +309,15 @@ WebInspector.DocumentationView.ContextMenuProvider.prototype = { |
| return; |
| if (descriptors.length === 1) { |
| var formatString = WebInspector.useLowerCaseMenuTitles() ? "Show documentation for %s.%s" : "Show Documentation for %s.%s"; |
| - contextMenu.appendItem(WebInspector.UIString(formatString, descriptors[0].name(), descriptors[0].searchItem()), WebInspector.DocumentationView.showDocumentationURL.bind(null, descriptors[0].url(), descriptors[0].searchItem())); |
| + var methodName = String.sprintf("%s.%s", descriptors[0].name(), descriptors[0].searchItem()); |
| + contextMenu.appendItem(WebInspector.UIString(formatString, descriptors[0].name(), descriptors[0].searchItem()), WebInspector.DocumentationView.showDocumentationURL.bind(null, descriptors[0].url(), methodName)); |
| return; |
| } |
| var subMenuItem = contextMenu.appendSubMenuItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Show documentation for..." : "Show Documentation for...")); |
| - for (var i = 0; i < descriptors.length; ++i) |
| - subMenuItem.appendItem(String.sprintf("%s.%s", descriptors[i].name(), descriptors[i].searchItem()), WebInspector.DocumentationView.showDocumentationURL.bind(null, descriptors[i].url(), descriptors[i].searchItem())); |
| + for (var i = 0; i < descriptors.length; ++i) { |
| + var methodName = String.sprintf("%s.%s", descriptors[i].name(), descriptors[i].searchItem()); |
| + subMenuItem.appendItem(methodName, WebInspector.DocumentationView.showDocumentationURL.bind(null, descriptors[i].url(), methodName)); |
| + } |
| }, |
| /** |