DevTools: [Documentation] Add signature section for renderer

Source/devtools/front_end/documentation/DocumentationURLProvider.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  */
 WebInspector.DocumentationURLProvider = function()
 {
     this._gapFromIndex = 0;
@@ skipping 56 matching lines @@
      * @return {string}
      */
     searchItem: function()
     {
         return this._searchItem;
     }
 }
 
 /**
  * @constructor
- * FIXME: source parameter is not annotated property due to crbug.com/407097
+ * FIXME: source parameter is not annotated properly due to crbug.com/407097
  * @param {*} source
  * @param {string} url
  * @param {string} name
  */
 WebInspector.DocumentationURLProvider.DocumentationSource = function(source, url, name)
 {
     this._source = source;
     this._url = url;
     this._name = name;
 }
@@ skipping 67 matching lines @@
     "javascript/"
 ];
 
 WebInspector.DocumentationURLProvider.prototype = {
     /**
      * @param {string} searchTerm
      * @return {!Array.<!WebInspector.DocumentationURLProvider.ItemDescriptor>}
      */
     itemDescriptors: function(searchTerm)
     {
-        if (this._state === WebInspector.DocumentationURLProvider.DownloadStates.Finished)
-            return this._articleList.get(searchTerm) || [];
+        if (this._state === WebInspector.DocumentationURLProvider.DownloadStates.Finished) {
+            if (searchTerm.toUpperCase() !== searchTerm)

[loislo, 2014/09/09 09:14:44]

I meant if download has been finished then you need to return the answer despite
the fact is it a constant or not. 

[loislo, 2014/09/09 11:07:40]

Looks like we should return the answer immediately if the search term is a
constant.
and fetch the pages in the other case.

+                return this._articleList.get(searchTerm) || [];
+        }
         // If download of available articles list is not finished yet, use approximate method.
         if (this._state === WebInspector.DocumentationURLProvider.DownloadStates.NotStarted)
             this._loadArticleList();
 
         var descriptors = [];
         var sources = WebInspector.DocumentationURLProvider._sources;
         var propertyName = searchTerm.toUpperCase() === searchTerm ? "constants" : searchTerm;
         for (var i = 0; i < sources.length; ++i) {
-            if (!sources[i].source().hasOwnProperty(propertyName))
+            if (!sources[i].source().hasOwnProperty(searchTerm) || this._inheritedFromFunction(sources[i].source(), searchTerm))
                 continue;
             descriptors.push(new WebInspector.DocumentationURLProvider.ItemDescriptor(sources[i], propertyName));
         }
         return descriptors;
     },
 
     _loadArticleList: function()
     {
         this._state = WebInspector.DocumentationURLProvider.DownloadStates.InProgress;
 
@@ skipping 40 matching lines @@
     },
 
     /**
      * @param {string} itemPath
      */
     _addDescriptorToList: function(itemPath)
     {
         var lastSlashIndex = itemPath.lastIndexOf("/");
         if (lastSlashIndex === -1)
             return;
+        var sourceName = itemPath.substring(0, lastSlashIndex + 1);
         // There are some properties which have several words in their name.
         // In article list they are written through gap, while in URL they are written through underscore.
         // We are creating URL for current property, so we have to replace all the gaps with underscores.
-        var correctedItemPath = itemPath.replace(" ", "_");
-        var sourceName = correctedItemPath.substring(0, lastSlashIndex + 1);
-        var propertyName = correctedItemPath.substring(lastSlashIndex + 1);
+        var propertyName = itemPath.substring(lastSlashIndex + 1).replace(" ", "_");
         var sources = WebInspector.DocumentationURLProvider._sources;
         for (var i = 0; i < sources.length; ++i) {
-            if (sources[i].url() !== sourceName || !sources[i].source().hasOwnProperty(propertyName))
+            if (sources[i].url() !== sourceName || !sources[i].source().hasOwnProperty(propertyName) || this._inheritedFromFunction(sources[i].source(), propertyName))
                 continue;
             var descriptors = this._articleList.get(propertyName) || [];
             descriptors.push(new WebInspector.DocumentationURLProvider.ItemDescriptor(sources[i], propertyName));
             this._articleList.set(propertyName, descriptors);
         }
+    },
+
+    /**
+     * FIXME: object parameter is not annotated properly due to crbug.com/407097
+     * @param {*} object
+     * @param {string} propertyName
+     * @return {boolean}
+     */
+    _inheritedFromFunction: function(object, propertyName)
+    {
+        return (object instanceof Function && object.hasOwnProperty(propertyName) && Function.hasOwnProperty(propertyName));
     }
 }