Source/bindings/tests/results/V8TestInterfaceDocument.cpp - Issue 525353002: [oilpan]: optimize the way we allocate persistent handles in wrappers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestInterfaceDocument.cpp

Issue 525353002: [oilpan]: optimize the way we allocate persistent handles in wrappers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: more review feedback Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/V8TestInterfaceDocument.h ('k') | Source/bindings/tests/results/V8TestInterfaceEmpty.h » ('j') | Source/platform/heap/Handle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestInterfaceDocument.cpp

diff --git a/Source/bindings/tests/results/V8TestInterfaceDocument.cpp b/Source/bindings/tests/results/V8TestInterfaceDocument.cpp

index 2d6eb49c1916189df618543bbc3dc292d2418352..818293d0f4930a645eb5954f8f7b08f138be7bb0 100644

--- a/Source/bindings/tests/results/V8TestInterfaceDocument.cpp

+++ b/Source/bindings/tests/results/V8TestInterfaceDocument.cpp

@@ -147,10 +147,10 @@ void V8TestInterfaceDocument::derefObject(ScriptWrappableBase* internalPointer)

#endif

}

-PersistentNode* V8TestInterfaceDocument::createPersistentHandle(ScriptWrappableBase* internalPointer)

+WrapperPersistentNode* V8TestInterfaceDocument::createPersistentHandle(ScriptWrappableBase* internalPointer)

{

#if ENABLE(OILPAN)

- return new Persistent<TestInterfaceDocument>(fromInternalPointer(internalPointer));

+ return new WrapperPersistent<TestInterfaceDocument>(fromInternalPointer(internalPointer));

#else

ASSERT_NOT_REACHED();

return 0;