Source/bindings/tests/results/V8TestInterfaceConstructor2.h - Issue 525353002: [oilpan]: optimize the way we allocate persistent handles in wrappers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestInterfaceConstructor2.h

Issue 525353002: [oilpan]: optimize the way we allocate persistent handles in wrappers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: more review feedback Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/V8TestInterfaceConstructor.cpp ('k') | Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp » ('j') | Source/platform/heap/Handle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestInterfaceConstructor2.h

diff --git a/Source/bindings/tests/results/V8TestInterfaceConstructor2.h b/Source/bindings/tests/results/V8TestInterfaceConstructor2.h

index 99d0c8ea866468fb26bcdc5ea72076197bc709e7..e6469632dd710a931136d4048b92694116083b4d 100644

--- a/Source/bindings/tests/results/V8TestInterfaceConstructor2.h

+++ b/Source/bindings/tests/results/V8TestInterfaceConstructor2.h

@@ -29,7 +29,7 @@ public:

static const WrapperTypeInfo wrapperTypeInfo;

static void refObject(ScriptWrappableBase* internalPointer);

static void derefObject(ScriptWrappableBase* internalPointer);

- static PersistentNode* createPersistentHandle(ScriptWrappableBase* internalPointer);

+ static WrapperPersistentNode* createPersistentHandle(ScriptWrappableBase* internalPointer);

static void constructorCallback(const v8::FunctionCallbackInfo<v8::Value>&);

static const int internalFieldCount = v8DefaultWrapperInternalFieldCount + 0;

static inline ScriptWrappableBase* toInternalPointer(TestInterfaceConstructor2* impl)