Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Unified Diff: Source/core/inspector/InjectedScriptManager.h

Issue 525353002: [oilpan]: optimize the way we allocate persistent handles in wrappers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/InjectedScriptManager.h
diff --git a/Source/core/inspector/InjectedScriptManager.h b/Source/core/inspector/InjectedScriptManager.h
index 289613a5dbfdb75e063fa28b9780d85da15a3a31..f35fb937731b805206562b1cb832e5d8fad30efd 100644
--- a/Source/core/inspector/InjectedScriptManager.h
+++ b/Source/core/inspector/InjectedScriptManager.h
@@ -49,8 +49,17 @@ class InjectedScriptManager : public NoBaseWillBeGarbageCollectedFinalized<Injec
public:
struct CallbackData {
ScopedPersistent<v8::Object> handle;
- RefPtrWillBePersistent<InjectedScriptHost> host;
+#if ENABLE(OILPAN)
+ WrapperPersistent<InjectedScriptHost>* hostPtr;
zerny-chromium 2014/09/01 14:13:37 Why the name change?
haraken 2014/09/02 05:22:05 InjectedScriptManager is a very special case, so y
wibling-chromium 2014/09/02 11:19:37 If i don't change it I cannot change the setXXX me
wibling-chromium 2014/09/02 11:19:37 Since it it now a pointer to the WrapperPersistent
+#else
+ RefPtr<InjectedScriptHost> host;
+#endif
InjectedScriptManager* injectedScriptManager;
+
+#if ENABLE(OILPAN)
+ CallbackData() : hostPtr(0) { }
+ ~CallbackData();
+#endif
};
static PassOwnPtrWillBeRawPtr<InjectedScriptManager> createForPage();

Powered by Google App Engine
This is Rietveld 408576698