Source/bindings/templates/interface.cpp - Issue 525353002: [oilpan]: optimize the way we allocate persistent handles in wrappers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/interface.cpp

Issue 525353002: [oilpan]: optimize the way we allocate persistent handles in wrappers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp ('K') | « Source/bindings/templates/interface.h ('k') | Source/bindings/tests/results/V8SVGTestInterface.h » ('j') | Source/core/inspector/InjectedScriptManager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/templates/interface.cpp

diff --git a/Source/bindings/templates/interface.cpp b/Source/bindings/templates/interface.cpp

index c9bb60f5f998efc228bf66a848d2a0b512b45f2a..5d7b5e3287d9530d165fbff871e27b73dc0a1fe7 100644

--- a/Source/bindings/templates/interface.cpp

+++ b/Source/bindings/templates/interface.cpp

@@ -1246,13 +1246,13 @@ void {{v8_class}}::derefObject(ScriptWrappableBase* internalPointer)

{% endif %}

}

-PersistentNode* {{v8_class}}::createPersistentHandle(ScriptWrappableBase* internalPointer)

+WrapperPersistentNode* {{v8_class}}::createPersistentHandle(ScriptWrappableBase* internalPointer)

{

{% if gc_type == 'GarbageCollectedObject' %}

- return new Persistent<{{cpp_class}}>(fromInternalPointer(internalPointer));

+ return new WrapperPersistent<{{cpp_class}}>(fromInternalPointer(internalPointer));

{% elif gc_type == 'WillBeGarbageCollectedObject' %}

#if ENABLE(OILPAN)

- return new Persistent<{{cpp_class}}>(fromInternalPointer(internalPointer));

+ return new WrapperPersistent<{{cpp_class}}>(fromInternalPointer(internalPointer));

#else

ASSERT_NOT_REACHED();

return 0;