Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 525343002: Do not clear weak monomorphic IC after context disposal. (Closed)

Created:
6 years, 3 months ago by ulan
Modified:
6 years, 3 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Do not clear weak monomorphic IC after context disposal. BUG=404020 LOG=Y R=jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23564

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/heap/objects-visiting-inl.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
ulan
PTAL. The main purpose of flushing ICs is to prevent memory leaks. This CL should ...
6 years, 3 months ago (2014-09-01 11:01:53 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-01 13:18:13 UTC) #3
ulan
6 years, 3 months ago (2014-09-01 13:40:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23564 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698