Issue 52533003: Refactor TextTrackLoader to properly use the dataReceived callback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 52533003: Refactor TextTrackLoader to properly use the dataReceived callback (Closed)

Created:
7 years, 1 month ago by philipj_slow

Modified:
7 years, 1 month ago

Reviewers:
Nate Chapin

CC:
blink-reviews, Nate Chapin, nessy, vcarbune.chromium, philipj_slow, gavinp+loader_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@cachedCueData

Visibility:
Public.

More Reviews

Description

Refactor TextTrackLoader to properly use the dataReceived callback We get the data and length in the callback, so just use it directly. This accidentally fixes a parsing test, by changing the segmentation of the input received by the WebVTT parser. A separate bug was filed to fix the problem: http://crbug.com/313222 BUG=312756 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160965

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -32 lines)			Patch
M	LayoutTests/media/track/opera/track/webvtt/parsing/001-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/loader/TextTrackLoader.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	Source/core/loader/TextTrackLoader.cpp	View	3 chunks	+5 lines, -29 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/52533003/1

7 years, 1 month ago (2013-10-30 18:12:19 UTC) #3

Message was sent while issue was closed.

Change committed as 160965

Expand Messages | Collapse Messages