Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 52533003: Refactor TextTrackLoader to properly use the dataReceived callback (Closed)

Created:
4 years, 10 months ago by philipj_slow
Modified:
4 years, 10 months ago
Reviewers:
Nate Chapin
CC:
blink-reviews, Nate Chapin, nessy, vcarbune.chromium, philipj_slow, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@cachedCueData
Visibility:
Public.

Description

Refactor TextTrackLoader to properly use the dataReceived callback We get the data and length in the callback, so just use it directly. This accidentally fixes a parsing test, by changing the segmentation of the input received by the WebVTT parser. A separate bug was filed to fix the problem: http://crbug.com/313222 BUG=312756 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160965

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -32 lines) Patch
M LayoutTests/media/track/opera/track/webvtt/parsing/001-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/TextTrackLoader.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/loader/TextTrackLoader.cpp View 3 chunks +5 lines, -29 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
philipj_slow
Part 3/4.
4 years, 10 months ago (2013-10-30 13:19:19 UTC) #1
Nate Chapin
lgtm
4 years, 10 months ago (2013-10-30 16:28:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/52533003/1
4 years, 10 months ago (2013-10-30 18:12:19 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2013-10-30 20:11:53 UTC) #4
Message was sent while issue was closed.
Change committed as 160965

Powered by Google App Engine
This is Rietveld 408576698