SyncSocket Transit Descriptor - refactoring

base/sync_socket_posix.cc

Index: base/sync_socket_posix.cc
diff --git a/base/sync_socket_posix.cc b/base/sync_socket_posix.cc
index 93a01d1b1c20699e134136c47d403f26837c9f44..4a6a5e920894c10c6df417b55aeb5fcb643a529f 100644
--- a/base/sync_socket_posix.cc
+++ b/base/sync_socket_posix.cc
@@ -96,6 +96,21 @@ bool SyncSocket::CreatePair(SyncSocket* socket_a, SyncSocket* socket_b) {
   return true;
 }
 
+// static
+SyncSocket::Handle SyncSocket::UnwrapHandle(
+    const SyncSocket::TransitDescriptor& descriptor) {
+  return static_cast<SyncSocket::Handle>(descriptor.fd);
+}
+
+bool SyncSocket::PrepareTransitDescriptor(
+    ProcessHandle peer_process_handle,
+    SyncSocket::TransitDescriptor* descriptor) {
+  // |TransitDescriptor| on POSIX is a |FileDescriptor|.
+  descriptor->fd = handle();
+  descriptor->auto_close = false;
+  return (descriptor->fd != -1);

[tommi (sloooow) - chröme, 2014/09/04 11:34:10]

Should you be using kInvalidHandle here?

nit: () not necessary

[burnik, 2014/09/04 12:24:43]

Done.

+}
+
 bool SyncSocket::Close() {
   const bool retval = CloseHandle(handle_);
   handle_ = kInvalidHandle;