content/browser/renderer_host/media/audio_sync_reader.h - Issue 525313002: SyncSocket Transit Descriptor - refactoring

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/audio_sync_reader.h

Issue 525313002: SyncSocket Transit Descriptor - refactoring (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add DCHECK on posix for descriptor pointer Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/media/audio_sync_reader.h

diff --git a/content/browser/renderer_host/media/audio_sync_reader.h b/content/browser/renderer_host/media/audio_sync_reader.h

index d596d1b4c0e7a9a7629e34002758771e3f39deec..63cfface67c62ec7d6e0bcb2b6c92704dc762b29 100644

--- a/content/browser/renderer_host/media/audio_sync_reader.h

+++ b/content/browser/renderer_host/media/audio_sync_reader.h

@@ -39,12 +39,8 @@ class AudioSyncReader : public media::AudioOutputController::SyncReader {

virtual void Close() OVERRIDE;

bool Init();

- bool PrepareForeignSocketHandle(base::ProcessHandle process_handle,

-#if defined(OS_WIN)

- base::SyncSocket::Handle* foreign_handle);

-#else

- base::FileDescriptor* foreign_handle);

-#endif

+ bool PrepareForeignSocket(base::ProcessHandle process_handle,

+ base::SyncSocket::TransitDescriptor* descriptor);

private:

// Blocks until data is ready for reading or a timeout expires. Returns false