SyncSocket Transit Descriptor - refactoring

base/sync_socket_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/sync_socket.h"
 
 #include "base/logging.h"
 #include "base/threading/thread_restrictions.h"
 #include "base/win/scoped_handle.h"
 
@@ skipping 189 matching lines @@
 
 SyncSocket::~SyncSocket() {
   Close();
 }
 
 // static
 bool SyncSocket::CreatePair(SyncSocket* socket_a, SyncSocket* socket_b) {
   return CreatePairImpl(&socket_a->handle_, &socket_b->handle_, false);
 }
 
+// static
+SyncSocket::Handle SyncSocket::UnwrapHandle(
+    const SyncSocket::TransitDescriptor& descriptor) {
+  return static_cast<SyncSocket::Handle>(descriptor);
+}
+
+bool SyncSocket::PrepareTransitDescriptor(
+    ProcessHandle peer_process_handle,
+    SyncSocket::TransitDescriptor* descriptor) {
+  DCHECK(descriptor);
+  *descriptor = 0;
+  if (!::DuplicateHandle(GetCurrentProcess(), handle(), peer_process_handle,
+                         descriptor, 0, FALSE, DUPLICATE_SAME_ACCESS)) {
+    DPLOG(ERROR) << "Cannot duplicate socket handle for peer process.";
+    return false;
+  }
+  if (*descriptor == 0) {

[tommi (sloooow) - chröme, 2014/09/04 17:02:25]

I would remove this block.  If DuplicateHandle has succeeded and *descriptor is
NULL, then the world is not what we expect it to be :)

Checking for NULL (preferred over 0 for HANDLE), might also not be correct
anyway since INVALID_HANDLE_VALUE on windows, is -1 (that's also what
kInvalidHandle is set to).

[burnik, 2014/09/04 18:04:07]

Done.

+    NOTREACHED() << "Socket handle duplicated but equals to zero.";
+    return false;
+  }
+  return true;
+}
+
 bool SyncSocket::Close() {
   if (handle_ == kInvalidHandle)
     return true;
 
   const BOOL result = CloseHandle(handle_);
   handle_ = kInvalidHandle;
   return result == TRUE;
 }
 
 size_t SyncSocket::Send(const void* buffer, size_t length) {
@@ skipping 88 matching lines @@
       &file_operation_, &shutdown_event_, this, timeout.InMilliseconds());
 }
 
 // static
 bool CancelableSyncSocket::CreatePair(CancelableSyncSocket* socket_a,
                                       CancelableSyncSocket* socket_b) {
   return CreatePairImpl(&socket_a->handle_, &socket_b->handle_, true);
 }
 
 }  // namespace base