Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 525283002: Enable highQualityFilter_SSE2 (Closed)

Created:
6 years, 3 months ago by qiankun
Modified:
6 years, 3 months ago
Reviewers:
humper, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Enable highQualityFilter_SSE2 With SSE2, bitmap_BGRA_8888_A_scale_rotate_bicubic gains about 40% performance improvement on desktop i7-3770. BUG=skia: Committed: https://skia.googlesource.com/skia/+/b381fa10d8079c58928058bb8a6db32b39f05e51 CQ_EXTRA_TRYBOTS=tryserver.skia:Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release-Trybot Committed: https://skia.googlesource.com/skia/+/f31507b240a27b7f7f3db9a92db4d4076e69c2ee

Patch Set 1 #

Patch Set 2 : fix mac gm test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -31 lines) Patch
M src/opts/SkBitmapFilter_opts_SSE2.cpp View 1 2 chunks +30 lines, -30 lines 0 comments Download
M src/opts/opts_check_x86.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (3 generated)
qiankun
PTAL.
6 years, 3 months ago (2014-09-01 06:18:20 UTC) #2
mtklein
This looks good to me. Humper, I'll leave it to you to why we've got ...
6 years, 3 months ago (2014-09-03 13:30:59 UTC) #3
humper
On 2014/09/03 13:30:59, mtklein wrote: > This looks good to me. Humper, I'll leave it ...
6 years, 3 months ago (2014-09-03 14:59:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/qiankun.miao@intel.com/525283002/1
6 years, 3 months ago (2014-09-03 15:16:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as b381fa10d8079c58928058bb8a6db32b39f05e51
6 years, 3 months ago (2014-09-03 15:24:17 UTC) #7
mtklein
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/539523002/ by mtklein@google.com. ...
6 years, 3 months ago (2014-09-03 15:54:00 UTC) #8
qiankun
On 2014/09/03 15:54:00, mtklein wrote: > A revert of this CL (patchset #1 id:1) has ...
6 years, 3 months ago (2014-09-04 05:03:00 UTC) #9
mtklein
lgtm
6 years, 3 months ago (2014-09-04 13:45:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/qiankun.miao@intel.com/525283002/20001
6 years, 3 months ago (2014-09-04 13:45:51 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-04 14:36:44 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as f31507b240a27b7f7f3db9a92db4d4076e69c2ee

Powered by Google App Engine
This is Rietveld 408576698