Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 525193004: Merge heap unit tests into src. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer
Modified:
6 years, 3 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Merge heap unit tests into src. Also rip out the unused runtime-unittests; will be added back on-demand. BUG=v8:3489 LOG=n R=ulan@chromium.org, svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23545

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -672 lines) Patch
M build/all.gyp View 1 chunk +2 lines, -3 lines 0 comments Download
A + src/heap/gc-idle-time-handler-unittest.cc View 8 chunks +41 lines, -10 lines 0 comments Download
A + src/heap/heap.gyp View 1 chunk +2 lines, -3 lines 0 comments Download
D test/heap-unittests/DEPS View 1 chunk +0 lines, -7 lines 0 comments Download
D test/heap-unittests/heap-unittest.h View 1 chunk +0 lines, -42 lines 0 comments Download
D test/heap-unittests/heap-unittest.cc View 1 chunk +0 lines, -213 lines 0 comments Download
D test/heap-unittests/heap-unittests.h View 1 chunk +0 lines, -42 lines 0 comments Download
D test/heap-unittests/heap-unittests.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D test/heap-unittests/heap-unittests.gyp View 1 chunk +0 lines, -53 lines 0 comments Download
D test/runtime-unittests/DEPS View 1 chunk +0 lines, -7 lines 0 comments Download
D test/runtime-unittests/runtime-unittests.h View 1 chunk +0 lines, -42 lines 0 comments Download
D test/runtime-unittests/runtime-unittests.cc View 1 chunk +0 lines, -88 lines 0 comments Download
D test/runtime-unittests/runtime-unittests.gyp View 1 chunk +0 lines, -53 lines 0 comments Download
D test/runtime-unittests/runtime-unittests.status View 1 chunk +0 lines, -6 lines 0 comments Download
D test/runtime-unittests/testcfg.py View 1 chunk +0 lines, -52 lines 0 comments Download
M tools/presubmit.py View 1 chunk +1 line, -3 lines 0 comments Download
M tools/run-tests.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Benedikt Meurer
6 years, 3 months ago (2014-09-01 09:00:50 UTC) #1
Benedikt Meurer
PTAL Ulan, Hannes: FYI
6 years, 3 months ago (2014-09-01 09:02:33 UTC) #3
ulan
lgtm
6 years, 3 months ago (2014-09-01 09:11:28 UTC) #4
Benedikt Meurer
Committed patchset #1 (id:1) manually as 23545 (presubmit successful).
6 years, 3 months ago (2014-09-01 09:13:07 UTC) #5
Hannes Payer (out of office)
6 years, 3 months ago (2014-09-08 12:46:37 UTC) #6
Message was sent while issue was closed.
Since we are going to have the test directory *forever*, I do not think we
should add the new unit tests to src. This just results in inconsistency.

Powered by Google App Engine
This is Rietveld 408576698