Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 525113005: Revert of Add gamma/sRGB tag to SkImageInfo (Closed)

Created:
6 years, 3 months ago by reed2
Modified:
6 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Add gamma/sRGB tag to SkImageInfo (patchset #1 id:1 of https://codereview.chromium.org/522813002/) Reason for revert: seems to be breaking layout tests in roll Original issue's description: > Add gamma/sRGB tag to SkImageInfo > > This reverts commit 64ba5fa1ff428858f803523257cd862f8b33423b. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/c89aa509d6a094bc1b18d73135343819903a9cfb TBR=reed@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/b44c1895afae516cb851cd1a0cea83343c354ee4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -240 lines) Patch
M gyp/tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkImageInfo.h View 4 chunks +25 lines, -64 lines 0 comments Download
M src/core/SkImageInfo.cpp View 2 chunks +21 lines, -111 lines 0 comments Download
D tests/ImageInfoTest.cpp View 1 chunk +0 lines, -64 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
reed2
Created Revert of Add gamma/sRGB tag to SkImageInfo
6 years, 3 months ago (2014-09-01 21:27:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/525113005/1
6 years, 3 months ago (2014-09-01 21:28:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as b44c1895afae516cb851cd1a0cea83343c354ee4
6 years, 3 months ago (2014-09-01 21:28:36 UTC) #3
reed2
Failure from before http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/22966/steps/webkit_unit_tests/logs/stdio [ RUN ] DeferredImageDecoderTest.drawIntoSkPicture ../../third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp:172: Failure Value of: canvasBitmap.getColor(0, 0) Actual: ...
6 years, 3 months ago (2014-09-02 00:48:32 UTC) #4
reed2
6 years, 3 months ago (2014-09-02 01:35:45 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/532583002/ by reed@chromium.org.

The reason for reverting is: Experiment to see resulting failures.

Powered by Google App Engine
This is Rietveld 408576698