Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(27)

Issue 525079: Add autodetection of "intranet" redirection, for ISPs etc. that send typos an... (Closed)

Created:
10 years, 9 months ago by Peter Kasting
Modified:
9 years, 4 months ago
Reviewers:
eroman, Evan Martin
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org, PaweĊ‚ Hajdan Jr.
Visibility:
Public.

Description

Add autodetection of "intranet" redirection, for ISPs etc. that send typos and nonexistent addresses to custom pages, and plumb it to the code that puts up infobars when users type in a search that appears to be an intranet address, so we don't show these for erroneous cases. BUG=31556 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35807

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 7

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Total comments: 9

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Patch Set 10 : '' #

Patch Set 11 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+479 lines, -94 lines) Patch
M chrome/browser/alternate_nav_url_fetcher.h View 1 2 3 4 5 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/alternate_nav_url_fetcher.cc View 1 2 3 4 5 4 chunks +44 lines, -32 lines 0 comments Download
M chrome/browser/browser_main.cc View 1 2 3 4 5 2 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/browser_prefs.cc View 5 3 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/browser_process.h View 1 2 3 4 5 3 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/browser_process_impl.h View 1 2 3 4 5 4 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 2 3 4 5 4 chunks +15 lines, -5 lines 0 comments Download
M chrome/browser/extensions/cross_origin_xhr_apitest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/execute_script_apitest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_history_apitest.cc View 1 chunk +2 lines, -1 line 0 comments Download
MM chrome/browser/extensions/extension_javascript_url_apitest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/incognito_noscript_apitest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/first_run.h View 1 2 3 4 5 3 chunks +7 lines, -3 lines 0 comments Download
A chrome/browser/intranet_redirect_detector.h View 1 2 3 4 5 1 chunk +106 lines, -0 lines 0 comments Download
A chrome/browser/intranet_redirect_detector.cc View 1 2 3 4 5 6 7 1 chunk +171 lines, -0 lines 0 comments Download
M chrome/browser/net/cookie_policy_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/privacy_blacklist/blacklist_manager_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 2 3 4 5 2 chunks +5 lines, -1 line 0 comments Download
M chrome/test/in_process_browser_test.h View 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/in_process_browser_test.cc View 6 7 8 5 chunks +8 lines, -2 lines 0 comments Download
M chrome/test/live_sync/live_bookmarks_sync_test.h View 9 10 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/test/live_sync/live_bookmarks_sync_test.cc View 9 10 3 chunks +8 lines, -1 line 0 comments Download
M chrome/test/testing_browser_process.h View 1 2 3 4 5 2 chunks +5 lines, -1 line 0 comments Download
M net/base/host_resolver_proc.h View 3 chunks +12 lines, -6 lines 0 comments Download
M net/base/host_resolver_proc.cc View 6 7 8 2 chunks +25 lines, -3 lines 0 comments Download
M net/base/mock_host_resolver.h View 2 chunks +7 lines, -5 lines 0 comments Download
M net/base/mock_host_resolver.cc View 4 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Peter Kasting
This isn't tested or in fact even compiled yet, but I figured it'd be OK ...
10 years, 9 months ago (2010-01-07 00:56:51 UTC) #1
Evan Martin
Seems all right. I worry about perceived overhead of all of these HTTP requests. http://codereview.chromium.org/525079/diff/3001/32 ...
10 years, 9 months ago (2010-01-07 01:14:58 UTC) #2
Peter Kasting
http://codereview.chromium.org/525079/diff/3001/37 File chrome/browser/intranet_redirect_detector.cc (right): http://codereview.chromium.org/525079/diff/3001/37#newcode63 chrome/browser/intranet_redirect_detector.cc:63: void IntranetRedirectDetector::StartFetchesIfPossible() { On 2010/01/07 01:14:59, Evan Martin wrote: ...
10 years, 9 months ago (2010-01-07 01:31:15 UTC) #3
Peter Kasting
Added a resolver proc for testing to prevent us from sending out real network requests ...
10 years, 8 months ago (2010-01-08 03:43:41 UTC) #4
eroman
LG on the HostResolverProc side of things. http://codereview.chromium.org/525079/diff/59/70 File chrome/browser/intranet_redirect_detector.cc (right): http://codereview.chromium.org/525079/diff/59/70#newcode166 chrome/browser/intranet_redirect_detector.cc:166: return ((host.length() ...
10 years, 8 months ago (2010-01-08 04:04:01 UTC) #5
Peter Kasting
http://codereview.chromium.org/525079/diff/59/69 File chrome/browser/intranet_redirect_detector.h (right): http://codereview.chromium.org/525079/diff/59/69#newcode97 chrome/browser/intranet_redirect_detector.h:97: class IntranetRedirectHostResolverProc : public net::HostResolverProc { On 2010/01/08 04:04:01, ...
10 years, 8 months ago (2010-01-08 04:52:01 UTC) #6
eroman
lgtm > unless you want to rewrite default handling to be "implied". I will look ...
10 years, 8 months ago (2010-01-08 05:20:56 UTC) #7
Peter Kasting
10 years, 8 months ago (2010-01-08 05:22:41 UTC) #8
On 2010/01/08 05:20:56, eroman wrote:
> > unless you want to rewrite default handling to be "implied".
> 
> I will look into doing that as a subsequent iteration.

TBH, it seems OK as-is to me...

Powered by Google App Engine
This is Rietveld 408576698