Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6215)

Unified Diff: chrome/common/extensions/update_manifest.cc

Issue 525073: Add some missing va_end calls to match va_start. (Closed)
Patch Set: Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/update_manifest.cc
diff --git a/chrome/common/extensions/update_manifest.cc b/chrome/common/extensions/update_manifest.cc
index 915020b7e32b7219d9675068b0e3de217d8350e4..d6317c134c408cea9792275f4d3b89361971e1bf 100644
--- a/chrome/common/extensions/update_manifest.cc
+++ b/chrome/common/extensions/update_manifest.cc
@@ -30,6 +30,7 @@ void UpdateManifest::ParseError(const char* details, ...) {
errors_ += "\r\n";
}
StringAppendV(&errors_, details, args);
+ va_end(args);
}
// Checks whether a given node's name matches |expected_name| and
@@ -75,6 +76,7 @@ static void XmlErrorFunc(void *context, const char *message, ...) {
va_start(args, message);
std::string* error = static_cast<std::string*>(context);
StringAppendV(error, message, args);
+ va_end(args);
}
// Utility class for cleaning up the xml document when leaving a scope.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698