Issue 525064: Fixed potential length miscalculations by limiting max size of arrays and strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 525064: Fixed potential length miscalculations by limiting max size of arrays and strings. (Closed)

Created:
10 years, 11 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Fixed potential length miscalculations by limiting max size of arrays and strings. Committed: http://code.google.com/p/v8/source/detail?r=3560

Created: 10 years, 11 months ago

	Unified diffs	Side-by-side diffs	Stats (+128 lines, -18 lines)
M	src/heap.cc	View	9 chunks	+37 lines, -3 lines	0 comments
M	src/objects.h	View	7 chunks	+35 lines, -0 lines	0 comments
M	src/objects.cc	View	1 chunk	+7 lines, -3 lines	0 comments
M	src/runtime.cc	View	8 chunks	+48 lines, -12 lines	0 comments
M	src/utils.cc	View	1 chunk	+1 line, -0 lines	0 comments

Total messages: 2 (0 generated)

Lasse Reichstein

Fix potential signed/unsigned size miscalculations and add extra safety checks. Please check that the size ...

10 years, 11 months ago (2010-01-06 10:01:04 UTC) #1

Mads Ager (chromium)

10 years, 11 months ago (2010-01-07 11:28:38 UTC) #2

LGTM

I guess the max sizes are as high as they can be to ensure that the computations
cannot overflow?