Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(28)

Issue 525064: Fixed potential length miscalculations by limiting max size of arrays and strings. (Closed)

Created:
7 years, 10 months ago by Lasse Reichstein
Modified:
6 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fixed potential length miscalculations by limiting max size of arrays and strings. Committed: http://code.google.com/p/v8/source/detail?r=3560

Patch Set 1 #

Patch Set 2 : Added (unrelated) cast to make Win64 compile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -18 lines) Patch
M src/heap.cc View 1 9 chunks +37 lines, -3 lines 0 comments Download
M src/objects.h View 7 chunks +35 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M src/runtime.cc View 8 chunks +48 lines, -12 lines 0 comments Download
M src/utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
Trybot results:

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
Fix potential signed/unsigned size miscalculations and add extra safety checks. Please check that the size ...
7 years, 10 months ago (2010-01-06 10:01:04 UTC) #1
Mads Ager (chromium)
7 years, 10 months ago (2010-01-07 11:28:38 UTC) #2
LGTM

I guess the max sizes are as high as they can be to ensure that the computations
cannot overflow?

Powered by Google App Engine
This is Rietveld efc10ee0f