Chromium Code Reviews
Help | Chromium Project | Sign in
(1148)

Issue 525064: Fixed potential length miscalculations by limiting max size of arrays and strings. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by Lasse Reichstein
Modified:
2 years, 10 months ago
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

Fixed potential length miscalculations by limiting max size of arrays and strings.

Committed: http://code.google.com/p/v8/source/detail?r=3560

Patch Set 1 #

Patch Set 2 : Added (unrelated) cast to make Win64 compile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -18 lines) Lint Patch
M src/heap.cc View 1 9 chunks +37 lines, -3 lines 0 comments 0 errors Download
M src/objects.h View 7 chunks +35 lines, -0 lines 0 comments 0 errors Download
M src/objects.cc View 1 chunk +7 lines, -3 lines 0 comments 0 errors Download
M src/runtime.cc View 8 chunks +48 lines, -12 lines 0 comments 0 errors Download
M src/utils.cc View 1 chunk +1 line, -0 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 2
Lasse Reichstein
Fix potential signed/unsigned size miscalculations and add extra safety checks. Please check that the size ...
4 years, 3 months ago #1
Mads Ager (chromium)
4 years, 3 months ago #2
LGTM

I guess the max sizes are as high as they can be to ensure that the computations
cannot overflow?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6