Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3954)

Unified Diff: chrome/browser/cocoa/browser_window_controller.mm

Issue 525002: Mac: Cmd-three finger swipe should open prev/next page in new tab. (Closed)
Patch Set: foo Created 10 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/cocoa/browser_window_controller.mm b/chrome/browser/cocoa/browser_window_controller.mm
index ab12bfbde53e285c25ce120cd97fd955f8aac5ba..d6bd3da0621a6af8a6c8dbb3bf9fbc4ad062c9ce 100644
--- a/chrome/browser/cocoa/browser_window_controller.mm
+++ b/chrome/browser/cocoa/browser_window_controller.mm
@@ -1447,14 +1447,15 @@ willPositionSheet:(NSWindow*)sheet
else if ([event deltaX] < -0.5)
command = IDC_FORWARD;
else if ([event deltaY] > 0.5)
- ; // TODO(pinkerton): figure out page-up
+ ; // TODO(pinkerton): figure out page-up, http://crbug.com/16305
else if ([event deltaY] < -0.5)
- ; // TODO(pinkerton): figure out page-down
+ ; // TODO(pinkerton): figure out page-down, http://crbug.com/16305
// Ensure the command is valid first (ExecuteCommand() won't do that) and
// then make it so.
if (browser_->command_updater()->IsCommandEnabled(command))
- browser_->ExecuteCommand(command);
+ browser_->ExecuteCommandWithDisposition(command,
+ event_utils::WindowOpenDispositionFromNSEvent(event));
}
// Delegate method called when window is resized.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698