Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 525002: Mac: Cmd-three finger swipe should open prev/next page in new tab. (Closed)

Created:
10 years, 11 months ago by Nico
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Mac: Cmd-three finger swipe should open prev/next page in new tab. BUG=29804 TEST=surf around, hold cmd, three-finger-swipe to the left. previous page should open in new tab. switch to new tab, hold cmd, three-finger-swipe to the right. original page should open in yet another tab. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35440

Patch Set 1 #

Total comments: 3

Patch Set 2 : foo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/cocoa/browser_window_controller.mm View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
10 years, 11 months ago (2010-01-03 00:33:50 UTC) #1
viettrungluu
http://codereview.chromium.org/525002/diff/1/2 File chrome/browser/cocoa/browser_window_controller.mm (right): http://codereview.chromium.org/525002/diff/1/2#newcode1458 chrome/browser/cocoa/browser_window_controller.mm:1458: event_utils::WindowOpenDispositionFromNSEvent([NSApp currentEvent])); Why |[NSApp currentEvent]| rather than |event|?
10 years, 11 months ago (2010-01-03 00:39:22 UTC) #2
Nico
http://codereview.chromium.org/525002/diff/1/2 File chrome/browser/cocoa/browser_window_controller.mm (right): http://codereview.chromium.org/525002/diff/1/2#newcode1458 chrome/browser/cocoa/browser_window_controller.mm:1458: event_utils::WindowOpenDispositionFromNSEvent([NSApp currentEvent])); On 2010/01/03 00:39:22, viettrungluu wrote: > Why ...
10 years, 11 months ago (2010-01-03 00:47:42 UTC) #3
viettrungluu
10 years, 11 months ago (2010-01-03 00:49:53 UTC) #4
LGTM.

http://codereview.chromium.org/525002/diff/1/2
File chrome/browser/cocoa/browser_window_controller.mm (right):

http://codereview.chromium.org/525002/diff/1/2#newcode1458
chrome/browser/cocoa/browser_window_controller.mm:1458:
event_utils::WindowOpenDispositionFromNSEvent([NSApp currentEvent]));
On 2010/01/03 00:47:42, Nico wrote:
> On 2010/01/03 00:39:22, viettrungluu wrote:
> > Why |[NSApp currentEvent]| rather than |event|?
> 
> |event| works too. I guess it saves a few bytes, done.

Plus it's correct, since it's |-swipeWithEvent:| (using the given event).

Powered by Google App Engine
This is Rietveld 408576698