Mac: Cmd-three finger swipe should open prev/next page in new tab.

Mac: Cmd-three finger swipe should open	  prev/next page in new tab.

BUG=29804
TEST=surf around, hold cmd, three-finger-swipe to the left. previous page should open in new tab. switch to new	tab, hold cmd, three-finger-swipe to the right. original page should open in yet another tab.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35440

[viettrungluu, 2010-01-03 00:39:22]

http://codereview.chromium.org/525002/diff/1/2
File chrome/browser/cocoa/browser_window_controller.mm (right):

http://codereview.chromium.org/525002/diff/1/2#newcode1458
chrome/browser/cocoa/browser_window_controller.mm:1458:
event_utils::WindowOpenDispositionFromNSEvent([NSApp currentEvent]));
Why |[NSApp currentEvent]| rather than |event|?

[Nico, 2010-01-03 00:47:42]

http://codereview.chromium.org/525002/diff/1/2
File chrome/browser/cocoa/browser_window_controller.mm (right):

http://codereview.chromium.org/525002/diff/1/2#newcode1458
chrome/browser/cocoa/browser_window_controller.mm:1458:
event_utils::WindowOpenDispositionFromNSEvent([NSApp currentEvent]));
On 2010/01/03 00:39:22, viettrungluu wrote:
> Why |[NSApp currentEvent]| rather than |event|?

|event| works too. I guess it saves a few bytes, done.

[viettrungluu, 2010-01-03 00:49:53]

LGTM.

http://codereview.chromium.org/525002/diff/1/2
File chrome/browser/cocoa/browser_window_controller.mm (right):

http://codereview.chromium.org/525002/diff/1/2#newcode1458
chrome/browser/cocoa/browser_window_controller.mm:1458:
event_utils::WindowOpenDispositionFromNSEvent([NSApp currentEvent]));
On 2010/01/03 00:47:42, Nico wrote:
> On 2010/01/03 00:39:22, viettrungluu wrote:
> > Why |[NSApp currentEvent]| rather than |event|?
> 
> |event| works too. I guess it saves a few bytes, done.

Plus it's correct, since it's |-swipeWithEvent:| (using the given event).