Move fileapi-related files from webkit/common/ to storage/common/ and set up redirect headers

Move fileapi-related files from webkit/common/ to storage/common/ and set up redirect headers

BUG=338338
TBR=darin@chromium.org

Committed: https://crrev.com/f55d19fce5e8521d5e269739e2e0e553dcb61bf2
Cr-Commit-Position: refs/heads/master@{#293228}

[pilgrim_google, 2014-08-30 02:44:29]

pilgrim@chromium.org changed reviewers:
+ darin@chromium.org, jam@chromium.org, jamesr@chromium.org

[jamesr, 2014-09-02 19:08:18]

The new directory will need an OWNERS file since webkit/OWNERS will no longer
apply

https://codereview.chromium.org/524983002/diff/40001/storage/common/blob/blob...
File storage/common/blob/blob_data.h (right):

https://codereview.chromium.org/524983002/diff/40001/storage/common/blob/blob...
storage/common/blob/blob_data.h:6: #define WEBKIT_COMMON_BLOB_BLOB_DATA_H_
this header guard isn't right.

tools/git/mass-rename.sh should update the header guards for you, assuming they
were correct to begin with

https://codereview.chromium.org/524983002/diff/40001/webkit/DEPS
File webkit/DEPS (right):

https://codereview.chromium.org/524983002/diff/40001/webkit/DEPS#newcode27
webkit/DEPS:27: "+storage",
storaget/ has a +webkit, so this is a cycle. are they really interdependent
today? is there a subset that one of these could rely on instead?

[pilgrim_google, 2014-09-02 21:14:48]

On 2014/09/02 19:08:18, jamesr wrote:
> The new directory will need an OWNERS file since webkit/OWNERS will no longer
> apply
> 
>
https://codereview.chromium.org/524983002/diff/40001/storage/common/blob/blob...
> File storage/common/blob/blob_data.h (right):
> 
>
https://codereview.chromium.org/524983002/diff/40001/storage/common/blob/blob...
> storage/common/blob/blob_data.h:6: #define WEBKIT_COMMON_BLOB_BLOB_DATA_H_
> this header guard isn't right.
> 
> tools/git/mass-rename.sh should update the header guards for you, assuming
they
> were correct to begin with
> 
> https://codereview.chromium.org/524983002/diff/40001/webkit/DEPS
> File webkit/DEPS (right):
> 
> https://codereview.chromium.org/524983002/diff/40001/webkit/DEPS#newcode27
> webkit/DEPS:27: "+storage",
> storaget/ has a +webkit, so this is a cycle. are they really interdependent
> today? is there a subset that one of these could rely on instead?

They are because data_element.cc|h is still in webkit. Moving it would collapse
webkit_common.gyp which would affect a bunch of other build files elsewhere.
Obviously we'll have to do that eventually but I was hoping to do it in a
separate CL.

Everything else is corrected.

[jamesr, 2014-09-02 21:35:31]

https://codereview.chromium.org/524983002/diff/80001/storage/DEPS
File storage/DEPS (right):

https://codereview.chromium.org/524983002/diff/80001/storage/DEPS#newcode5
storage/DEPS:5: "+webkit",
if you only need data_element.h, can you just do "+webkit/common/data_element.h"
here?

https://codereview.chromium.org/524983002/diff/80001/storage/common/blob/scop...
File storage/common/blob/scoped_file.cc (right):

https://codereview.chromium.org/524983002/diff/80001/storage/common/blob/scop...
storage/common/blob/scoped_file.cc:5: #include
"webkit/common/blob/scoped_file.h"
this doesn't look right...

https://codereview.chromium.org/524983002/diff/80001/storage/common/blob/scop...
File storage/common/blob/scoped_file.h (right):

https://codereview.chromium.org/524983002/diff/80001/storage/common/blob/scop...
storage/common/blob/scoped_file.h:14: #include
"webkit/common/storage_common_export.h"
can you move the export header too?

https://codereview.chromium.org/524983002/diff/80001/webkit/common/BUILD.gn
File webkit/common/BUILD.gn (right):

https://codereview.chromium.org/524983002/diff/80001/webkit/common/BUILD.gn#n...
webkit/common/BUILD.gn:27: "../../storage/common/blob/blob_data.cc",
why not move this to storage/common/BUILD.gn ?

https://codereview.chromium.org/524983002/diff/80001/webkit/storage_common.gyp
File webkit/storage_common.gyp (right):

https://codereview.chromium.org/524983002/diff/80001/webkit/storage_common.gy...
webkit/storage_common.gyp:24: '../storage/common/blob/blob_data.cc',
why not move this gyp file to storage/ ?

[pilgrim_google, 2014-09-03 14:52:16]

On 2014/09/02 21:35:31, jamesr wrote:
> https://codereview.chromium.org/524983002/diff/80001/storage/DEPS
> File storage/DEPS (right):
> 
> https://codereview.chromium.org/524983002/diff/80001/storage/DEPS#newcode5
> storage/DEPS:5: "+webkit",
> if you only need data_element.h, can you just do
"+webkit/common/data_element.h"
> here?
> 
>
https://codereview.chromium.org/524983002/diff/80001/storage/common/blob/scop...
> File storage/common/blob/scoped_file.cc (right):
> 
>
https://codereview.chromium.org/524983002/diff/80001/storage/common/blob/scop...
> storage/common/blob/scoped_file.cc:5: #include
> "webkit/common/blob/scoped_file.h"
> this doesn't look right...
> 
>
https://codereview.chromium.org/524983002/diff/80001/storage/common/blob/scop...
> File storage/common/blob/scoped_file.h (right):
> 
>
https://codereview.chromium.org/524983002/diff/80001/storage/common/blob/scop...
> storage/common/blob/scoped_file.h:14: #include
> "webkit/common/storage_common_export.h"
> can you move the export header too?
> 
> https://codereview.chromium.org/524983002/diff/80001/webkit/common/BUILD.gn
> File webkit/common/BUILD.gn (right):
> 
>
https://codereview.chromium.org/524983002/diff/80001/webkit/common/BUILD.gn#n...
> webkit/common/BUILD.gn:27: "../../storage/common/blob/blob_data.cc",
> why not move this to storage/common/BUILD.gn ?
> 
> https://codereview.chromium.org/524983002/diff/80001/webkit/storage_common.gyp
> File webkit/storage_common.gyp (right):
> 
>
https://codereview.chromium.org/524983002/diff/80001/webkit/storage_common.gy...
> webkit/storage_common.gyp:24: '../storage/common/blob/blob_data.cc',
> why not move this gyp file to storage/ ?

all done. storage/ no longer depends on webkit/. data_element.cc|h moved over.
build files moved over. gyp targets collapsed. references updated. rebased.

[jamesr, 2014-09-03 15:50:29]

Woohooo!  lgtm

could you verify that checkdeps runs cleanly for the targets that depend on
storage/ ? I'd suspect at least some directories will need "+storage/..." in
their DEPS files.  This step doesn't run on all of the trybots I've found (not
totally sure which it does/doesn't run on) but is pretty easy to run and fix up
locally.

https://codereview.chromium.org/524983002/diff/100001/storage/common/BUILD.gn
File storage/common/BUILD.gn (right):

https://codereview.chromium.org/524983002/diff/100001/storage/common/BUILD.gn...
storage/common/BUILD.gn:5: component("common") {
a comment saying # GYP version: storage/whatever.gyp:something would be nice

[pilgrim_google, 2014-09-03 16:23:05]

On 2014/09/03 15:50:29, jamesr wrote:
> Woohooo!  lgtm
> 
> could you verify that checkdeps runs cleanly for the targets that depend on
> storage/ ? I'd suspect at least some directories will need "+storage/..." in
> their DEPS files.  This step doesn't run on all of the trybots I've found (not
> totally sure which it does/doesn't run on) but is pretty easy to run and fix
up
> locally.

I put in redirect headers in webkit/common/ so this is not a problem until I
remove them (which I will, later).

> 
> https://codereview.chromium.org/524983002/diff/100001/storage/common/BUILD.gn
> File storage/common/BUILD.gn (right):
> 
>
https://codereview.chromium.org/524983002/diff/100001/storage/common/BUILD.gn...
> storage/common/BUILD.gn:5: component("common") {
> a comment saying # GYP version: storage/whatever.gyp:something would be nice

done

[pilgrim_google, 2014-09-03 17:03:23]

The CQ bit was checked by pilgrim@chromium.org

[commit-bot: I haz the power, 2014-09-03 17:05:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pilgrim@chromium.org/524983002/140001

[commit-bot: I haz the power, 2014-09-03 17:59:25]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[commit-bot: I haz the power, 2014-09-03 18:03:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-03 18:03:58]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pilgrim_google, 2014-09-03 20:06:51]

The CQ bit was checked by pilgrim@chromium.org

[commit-bot: I haz the power, 2014-09-03 20:08:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pilgrim@chromium.org/524983002/160001

[commit-bot: I haz the power, 2014-09-03 21:22:44]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[commit-bot: I haz the power, 2014-09-04 00:06:25]

Committed patchset #9 (id:160001) as e292682725a7343eb49fc587358dcd0214ae837c

[commit-bot: I haz the power, 2014-09-10 03:28:47]

Patchset 9 (id:??) landed as
https://crrev.com/f55d19fce5e8521d5e269739e2e0e553dcb61bf2
Cr-Commit-Position: refs/heads/master@{#293228}