Use shark requisition instead of command line parameter

Use shark requisition instead of command line parameter

BUG=None

Committed: https://crrev.com/5b2b51bd918fca3d7da9444e585f50e4c8f5600b
Cr-Commit-Position: refs/heads/master@{#293056}

[Zachary Kuznia, 2014-08-29 23:00:53]

zork@chromium.org changed reviewers:
+ achuith@chromium.org

[Zachary Kuznia, 2014-08-29 23:01:04]

Please take a look.

[achuithb, 2014-08-29 23:03:34]

https://codereview.chromium.org/524903003/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/wizard_controller.cc (right):

https://codereview.chromium.org/524903003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/wizard_controller.cc:109: bool
ShouldShowControllerPairingScreen() {
Why not get rid of this altogether?

https://codereview.chromium.org/524903003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/wizard_controller.cc:111:
g_browser_process->platform_part()->browser_policy_connector_chromeos()->
Might as well just return this instead of creating the temporary is_shark.

[Zachary Kuznia, 2014-08-29 23:27:10]

https://codereview.chromium.org/524903003/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/wizard_controller.cc (right):

https://codereview.chromium.org/524903003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/wizard_controller.cc:109: bool
ShouldShowControllerPairingScreen() {
On 2014/08/29 23:03:34, achuithb wrote:
> Why not get rid of this altogether?

Done.

https://codereview.chromium.org/524903003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/wizard_controller.cc:111:
g_browser_process->platform_part()->browser_policy_connector_chromeos()->
On 2014/08/29 23:03:34, achuithb wrote:
> Might as well just return this instead of creating the temporary is_shark.

Function removed.

[achuithb, 2014-08-29 23:53:12]

lgtm module dealing with the nit below.

https://codereview.chromium.org/524903003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/wizard_controller.cc (right):

https://codereview.chromium.org/524903003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/wizard_controller.cc:631: if
(g_browser_process->platform_part()->browser_policy_connector_chromeos()->
You'll probably hate me for saying this, but this line is long enough and hard
enough to read that const bool is_shark may be useful here.

The other option is to add a comment saying that we show the controller pairing
screen for shark devices.

Or maybe both?

[achuithb, 2014-08-29 23:53:25]

modulo

[dzhioev (left Google), 2014-09-01 16:52:51]

Hi, taking into account https://codereview.chromium.org/528803002, this CL is
not needed anymore.

[Zachary Kuznia, 2014-09-03 00:01:52]

On 2014/09/01 16:52:51, dzhioev wrote:
> Hi, taking into account https://codereview.chromium.org/528803002, this CL is
> not needed anymore.

I'm going to go ahead an land this, since that'll let you simplify your patch
slightly.

[Zachary Kuznia, 2014-09-03 00:01:59]

https://codereview.chromium.org/524903003/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/wizard_controller.cc (right):

https://codereview.chromium.org/524903003/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/wizard_controller.cc:631: if
(g_browser_process->platform_part()->browser_policy_connector_chromeos()->
On 2014/08/29 23:53:11, achuithb wrote:
> You'll probably hate me for saying this, but this line is long enough and hard
> enough to read that const bool is_shark may be useful here.
> 
> The other option is to add a comment saying that we show the controller
pairing
> screen for shark devices.
> 
> Or maybe both?

Done.

[Zachary Kuznia, 2014-09-03 00:02:24]

The CQ bit was checked by zork@chromium.org

[commit-bot: I haz the power, 2014-09-03 00:03:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zork@chromium.org/524903003/60001

[achuithb, 2014-09-03 00:05:04]

lgtm

[commit-bot: I haz the power, 2014-09-03 02:34:40]

Committed patchset #4 (id:60001) as 7ca838eb8e75795b7c06efe4f63ef2ed9c4d5771

[commit-bot: I haz the power, 2014-09-10 03:23:04]

Patchset 4 (id:??) landed as
https://crrev.com/5b2b51bd918fca3d7da9444e585f50e4c8f5600b
Cr-Commit-Position: refs/heads/master@{#293056}