Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Side by Side Diff: remoting/webapp/client_plugin.js

Issue 524843002: Don't print out extension message data if unrecognized. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix typo Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « remoting/host/client_session.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * Class that wraps low-level details of interacting with the client plugin. 7 * Class that wraps low-level details of interacting with the client plugin.
8 * 8 *
9 * This abstracts a <embed> element and controls the plugin which does 9 * This abstracts a <embed> element and controls the plugin which does
10 * the actual remoting work. It also handles differences between 10 * the actual remoting work. It also handles differences between
(...skipping 353 matching lines...) Expand 10 before | Expand all | Expand 10 after
364 case 'gnubby-auth': 364 case 'gnubby-auth':
365 this.onGnubbyAuthHandler(extMsgData); 365 this.onGnubbyAuthHandler(extMsgData);
366 break; 366 break;
367 case 'test-echo-reply': 367 case 'test-echo-reply':
368 console.log('Got echo reply: ' + extMsgData); 368 console.log('Got echo reply: ' + extMsgData);
369 break; 369 break;
370 case 'cast_message': 370 case 'cast_message':
371 this.onCastExtensionHandler(extMsgData); 371 this.onCastExtensionHandler(extMsgData);
372 break; 372 break;
373 default: 373 default:
374 if (!this.onExtensionMessage_(extMsgType, extMsgData)) { 374 this.onExtensionMessage_(extMsgType, extMsgData);
375 console.log('Unexpected message received: ' + 375 break;
376 extMsgType + ': ' + extMsgData);
377 }
378 } 376 }
379 377
380 } else if (message.method == 'mediaSourceReset') { 378 } else if (message.method == 'mediaSourceReset') {
381 if (!this.mediaSourceRenderer_) { 379 if (!this.mediaSourceRenderer_) {
382 console.error('Unexpected mediaSourceReset.'); 380 console.error('Unexpected mediaSourceReset.');
383 return; 381 return;
384 } 382 }
385 this.mediaSourceRenderer_.reset(getStringAttr(message.data, 'format')) 383 this.mediaSourceRenderer_.reset(getStringAttr(message.data, 'format'))
386 384
387 } else if (message.method == 'mediaSourceData') { 385 } else if (message.method == 'mediaSourceData') {
(...skipping 429 matching lines...) Expand 10 before | Expand all | Expand 10 after
817 * Undo the CSS rules needed to make the plugin clickable for click-to-play. 815 * Undo the CSS rules needed to make the plugin clickable for click-to-play.
818 * @private 816 * @private
819 */ 817 */
820 remoting.ClientPlugin.prototype.hidePluginForClickToPlay_ = function() { 818 remoting.ClientPlugin.prototype.hidePluginForClickToPlay_ = function() {
821 this.plugin_.style.width = ''; 819 this.plugin_.style.width = '';
822 this.plugin_.style.height = ''; 820 this.plugin_.style.height = '';
823 this.plugin_.style.top = ''; 821 this.plugin_.style.top = '';
824 this.plugin_.style.left = ''; 822 this.plugin_.style.left = '';
825 this.plugin_.style.position = ''; 823 this.plugin_.style.position = '';
826 }; 824 };
OLDNEW
« no previous file with comments | « remoting/host/client_session.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698