Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 524773004: Clean up forward declarations in Source/platform (Closed)

Created:
6 years, 3 months ago by rwlbuis
Modified:
6 years, 3 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, blink-reviews-events_chromium.org, Rik, danakj, dcheng, dglazkov+blink, krit, eae+blinkwatch, gavinp+prerender_chromium.org, jamesr, jbroman, pdr., rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Clean up forward declarations in Source/platform These forward references are not needed anymore. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181259

Patch Set 1 #

Patch Set 2 : Rebase against ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -51 lines) Patch
M Source/platform/HostWindow.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/platform/LengthBox.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/LifecycleNotifier.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/PlatformWheelEvent.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/platform/PopupMenu.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/Timer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/clipboard/ClipboardUtilities.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/credentialmanager/PlatformCredential.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/fonts/Font.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/fonts/FontCache.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/fonts/FontFallbackList.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/platform/fonts/FontPlatformData.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/platform/fonts/SimpleFontData.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/platform/fonts/WidthCache.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/geometry/FloatRect.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/geometry/LayoutSize.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/network/FormData.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/platform/network/HTTPParsers.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/platform/network/ResourceLoadTiming.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/network/SocketStreamHandleClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/speech/PlatformSpeechSynthesizer.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/text/LocaleMac.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/text/LocaleWin.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
rwlbuis
PTAL
6 years, 3 months ago (2014-08-29 21:47:30 UTC) #2
abarth-chromium
lgtm
6 years, 3 months ago (2014-09-02 19:56:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/524773004/1
6 years, 3 months ago (2014-09-02 19:57:13 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/platform/Prerender.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 3 months ago (2014-09-02 19:57:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/524773004/20001
6 years, 3 months ago (2014-09-02 20:17:05 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-02 21:21:25 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 181259

Powered by Google App Engine
This is Rietveld 408576698