Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Issue 524743002: More unused grit header script improvements: (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
tfarina, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@grit_clean_chromium_strings_401588_a_remove
Project:
chromium
Visibility:
Public.

Description

More unused grit header script improvements: - Rename to tools/resources/list_unused_grit_header.py. - Handle structures of type "FOO_{LEFT,RIGHT,TOP}". - Add ability to scan files and folders. NOTRY=true Committed: https://crrev.com/587325d3e6d51b6d05f00982cc088b1be64dd12a Cr-Commit-Position: refs/heads/master@{#292716}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -222 lines) Patch
A + tools/resources/list_unused_grit_header.py View 5 chunks +37 lines, -13 lines 0 comments Download
D tools/unused-grit-header.py View 1 chunk +0 lines, -209 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Lei Zhang
6 years, 3 months ago (2014-08-29 19:26:18 UTC) #2
Nico
lgtm
6 years, 3 months ago (2014-08-29 19:33:51 UTC) #3
tfarina
lgtm
6 years, 3 months ago (2014-08-29 20:25:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/524743002/1
6 years, 3 months ago (2014-08-29 23:19:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as daf3568d4cbc5910f282528b6f7062ef53c91025
6 years, 3 months ago (2014-08-29 23:32:20 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:11:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/587325d3e6d51b6d05f00982cc088b1be64dd12a
Cr-Commit-Position: refs/heads/master@{#292716}

Powered by Google App Engine
This is Rietveld 408576698