mojo/public/tools/bindings/generators/java_templates/struct_definition.tmpl - Issue 524703004: Mojo: validate nullability in Java serialization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/java_templates/struct_definition.tmpl

Issue 524703004: Mojo: validate nullability in Java serialization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Ben's comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/java/bindings/src/org/chromium/mojo/bindings/Encoder.java ('k') | mojo/public/tools/bindings/generators/mojom_java_generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/java_templates/struct_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/java_templates/struct_definition.tmpl b/mojo/public/tools/bindings/generators/java_templates/struct_definition.tmpl

index e8dd9acfdf89bdd4d561254ee9d1f572ca43d800..63d389880c9e20263c030704b8b91e1ba0e55091 100644

--- a/mojo/public/tools/bindings/generators/java_templates/struct_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/java_templates/struct_definition.tmpl

@@ -13,7 +13,7 @@ org.chromium.mojo.bindings.BindingsHelper.UNSPECIFIED_ARRAY_LENGTH

{% if kind|is_pointer_array_kind %}

{% set sub_kind = kind.kind %}

if ({{variable}} == null) {

- encoder{{level}}.encodeNullPointer({{offset}});

+ encoder{{level}}.encodeNullPointer({{offset}}, {{kind|is_nullable_kind|java_true_false}});

} else {

org.chromium.mojo.bindings.Encoder encoder{{level + 1}} = encoder{{level}}.encodePointerArray({{variable}}.length, {{offset}}, {{array_expected_length(kind)}});

for (int i{{level}} = 0; i{{level}} < {{variable}}.length; ++i{{level}}) {