Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 524673002: call shimStyling even if we have no template, because our extendee might have one (Closed)

Created:
6 years, 3 months ago by jakemac
Modified:
6 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

call shimStyling even if we have no template, because our extendee might have one BUG= http://dartbug.com/18171 R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=39707

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/polymer/lib/src/declaration.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
jakemac
We could add an additional check in here to check if we have an extendee ...
6 years, 3 months ago (2014-08-29 17:08:06 UTC) #2
Siggi Cherem (dart-lang)
lgtm
6 years, 3 months ago (2014-08-29 18:08:45 UTC) #3
jakemac
6 years, 3 months ago (2014-08-29 18:27:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 39707 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698