Issue 52463002: Rename TextTrackLoader::m_cachedCueData to m_resource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 52463002: Rename TextTrackLoader::m_cachedCueData to m_resource (Closed)

Created:
7 years, 1 month ago by philipj_slow

Modified:
7 years, 1 month ago

Reviewers:
Nate Chapin

CC:
blink-reviews, Nate Chapin, nessy, vcarbune.chromium, philipj_slow, gavinp+loader_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Rename TextTrackLoader::m_cachedCueData to m_resource It's only used to add and remove a client and the code doesn't know or care whether it's cached or not, just call it m_resource like in DocumentThreadableLoader. BUG=312756 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160953

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -12 lines)			Patch
	M	Source/core/loader/TextTrackLoader.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/core/loader/TextTrackLoader.cpp	View		5 chunks	+11 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

philipj_slow

Part 2/4. Yep, I found that splitting it some more was helpful :)

7 years, 1 month ago (2013-10-30 12:33:10 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/52463002/1

7 years, 1 month ago (2013-10-30 16:27:44 UTC) #3

Message was sent while issue was closed.

Change committed as 160953

Expand Messages | Collapse Messages