Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 52463002: Rename TextTrackLoader::m_cachedCueData to m_resource (Closed)

Created:
7 years, 1 month ago by philipj_slow
Modified:
7 years, 1 month ago
Reviewers:
Nate Chapin
CC:
blink-reviews, Nate Chapin, nessy, vcarbune.chromium, philipj_slow, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Rename TextTrackLoader::m_cachedCueData to m_resource It's only used to add and remove a client and the code doesn't know or care whether it's cached or not, just call it m_resource like in DocumentThreadableLoader. BUG=312756 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160953

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M Source/core/loader/TextTrackLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/TextTrackLoader.cpp View 5 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
philipj_slow
Part 2/4. Yep, I found that splitting it some more was helpful :)
7 years, 1 month ago (2013-10-30 12:33:10 UTC) #1
Nate Chapin
lgtm
7 years, 1 month ago (2013-10-30 16:26:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/52463002/1
7 years, 1 month ago (2013-10-30 16:27:44 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-10-30 17:41:28 UTC) #4
Message was sent while issue was closed.
Change committed as 160953

Powered by Google App Engine
This is Rietveld 408576698