Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
524623004:
Enabling overscroll/GestureNav for Athena. (Closed)
|
Created:
6 years, 3 months ago by mfomitchev Modified:
6 years, 3 months ago CC:
chromium-reviews, darin-cc_chromium.org, jam Base URL:
https://chromium.googlesource.com/chromium/src.git@master Project:
chromium Visibility:
Public. |
DescriptionEnabling overscroll/GestureNav for Athena.
BUG=401604
Committed: https://crrev.com/5ef7c0aff8c8e6c8328acfa4ee4ae0b0ccc33f36
Cr-Commit-Position: refs/heads/master@{#292918}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Removing blank lines #
Total comments: 4
Patch Set 3 : Rebase #Messages
Total messages: 17 (4 generated)
mfomitchev@chromium.org changed reviewers: + oshima@chromium.org, sadrul@chromium.org
lgtm Add 'gesture nav' in the CL description too https://codereview.chromium.org/524623004/diff/1/athena/content/web_activity.cc File athena/content/web_activity.cc (right): https://codereview.chromium.org/524623004/diff/1/athena/content/web_activity.... athena/content/web_activity.cc:23: Remove blank lines.
https://codereview.chromium.org/524623004/diff/1/athena/content/web_activity.cc File athena/content/web_activity.cc (right): https://codereview.chromium.org/524623004/diff/1/athena/content/web_activity.... athena/content/web_activity.cc:23: On 2014/08/29 19:36:54, sadrul wrote: > Remove blank lines. Done.
lgtm https://codereview.chromium.org/524623004/diff/20001/athena/content/web_activ... File athena/content/web_activity.cc (right): https://codereview.chromium.org/524623004/diff/20001/athena/content/web_activ... athena/content/web_activity.cc:228: return value != "0"; just out of curiosity, do you know why this flag uses 1/0 value instead of just a flag?
https://codereview.chromium.org/524623004/diff/20001/athena/content/web_activ... File athena/content/web_activity.cc (right): https://codereview.chromium.org/524623004/diff/20001/athena/content/web_activ... athena/content/web_activity.cc:228: return value != "0"; It's actually 0/1/2. 0 = off 1 = on, default screenshot-based UI 2 = on, simple UI with no screenshots used. It shows navigation arrows that slide in on the side when overscrolling.
The CQ bit was checked by mfomitchev@chromium.org
slgtm https://codereview.chromium.org/524623004/diff/20001/athena/content/web_activ... File athena/content/web_activity.cc (right): https://codereview.chromium.org/524623004/diff/20001/athena/content/web_activ... athena/content/web_activity.cc:228: return value != "0"; On 2014/08/29 20:40:50, mfomitchev wrote: > It's actually 0/1/2. > 0 = off > 1 = on, default screenshot-based UI > 2 = on, simple UI with no screenshots used. It shows navigation arrows that > slide in on the side when overscrolling. I see. Would you mind updating the comment in https://code.google.com/p/chromium/codesearch#chromium/src/content/public/com... in separate CL?
https://codereview.chromium.org/524623004/diff/20001/athena/content/web_activ... File athena/content/web_activity.cc (right): https://codereview.chromium.org/524623004/diff/20001/athena/content/web_activ... athena/content/web_activity.cc:228: return value != "0"; Done: https://codereview.chromium.org/519143002/
still lgtm On 2014/08/29 21:15:21, mfomitchev wrote: > https://codereview.chromium.org/524623004/diff/20001/athena/content/web_activ... > File athena/content/web_activity.cc (right): > > https://codereview.chromium.org/524623004/diff/20001/athena/content/web_activ... > athena/content/web_activity.cc:228: return value != "0"; > Done: https://codereview.chromium.org/519143002/ thanks!
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/48369) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/53699) android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...) android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...) android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...) android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...) android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...) chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...) win_chromium_compile_dbg on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/48397) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/53727) android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...) android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...) android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...) android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...) android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...) chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...) win_chromium_compile_dbg on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by mfomitchev@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mfomitchev@chromium.org/524623004/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as aec503d24809132bc05493103a6931188c06f5ee
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/5ef7c0aff8c8e6c8328acfa4ee4ae0b0ccc33f36 Cr-Commit-Position: refs/heads/master@{#292918} |
