Issue 524623003: Clang/Windows update script: copy the dynamic ASan RTL if present

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 524623003: Clang/Windows update script: copy the dynamic ASan RTL if present (Closed)

Created:
6 years, 3 months ago by Timur Iskhodzhanov

Modified:
6 years, 3 months ago

Reviewers:
hans

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Clang/Windows update script: copy the dynamic ASan RTL if present [Never mind, see CL 519823002 instead] BUG=345874 NOTRY=true

Patch Set 1 #

Total comments: 1

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -7 lines)			Patch
	M	tools/clang/scripts/update.py	View		2 chunks	+17 lines, -7 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

timurrrr@chromium.org changed reviewers: + hans@chromium.org

6 years, 3 months ago (2014-08-29 16:20:26 UTC) #1

hans

6 years, 3 months ago (2014-08-29 16:31:06 UTC) #3

lgtm with minor comment

https://codereview.chromium.org/524623003/diff/1/tools/clang/scripts/update.py
File tools/clang/scripts/update.py (right):

https://codereview.chromium.org/524623003/diff/1/tools/clang/scripts/update.p...
tools/clang/scripts/update.py:135: def CopyDirectoryContents(src, dst,
filename_filter=None):
Maybe define this with CopyFile above, and give it a comment.

Expand Messages | Collapse Messages