Source/core/html/HTMLElement.h - Issue 524593003: Resolve direction correctly when dir attribute is not in a defined state

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLElement.h

Issue 524593003: Resolve direction correctly when dir attribute is not in a defined state Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Incorporating review comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/html/direction-in-case-of-invalid-dir-attribute-expected.html ('k') | Source/core/html/HTMLElement.cpp » ('j') | Source/core/html/HTMLElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLElement.h

diff --git a/Source/core/html/HTMLElement.h b/Source/core/html/HTMLElement.h

index 7fa604f43b310b65b60b7294005a4b64cbc45dd3..e7add4de17d08f1d2857f4b8fbc3415102b9f612 100644

--- a/Source/core/html/HTMLElement.h

+++ b/Source/core/html/HTMLElement.h

@@ -81,6 +81,7 @@ public:

bool hasDirectionAuto() const;

TextDirection directionalityIfhasDirAutoAttribute(bool& isAuto) const;

+ TextDirection determineDirection() const;

virtual bool isHTMLUnknownElement() const { return false; }

virtual bool isPluginElement() const { return false; }