Source/core/html/forms/TextFieldInputType.cpp - Issue 524593003: Resolve direction correctly when dir attribute is not in a defined state

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/TextFieldInputType.cpp

Issue 524593003: Resolve direction correctly when dir attribute is not in a defined state Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Splitting CL into 2 Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/forms/TextFieldInputType.cpp

diff --git a/Source/core/html/forms/TextFieldInputType.cpp b/Source/core/html/forms/TextFieldInputType.cpp

index 1794ee257b71fb8ed582fb0e81a60406cb94ab21..199e2d77d67c38e770e040666e9a9acd97c33f57 100644

--- a/Source/core/html/forms/TextFieldInputType.cpp

+++ b/Source/core/html/forms/TextFieldInputType.cpp

@@ -469,7 +469,7 @@ bool TextFieldInputType::appendFormData(FormDataList& list, bool multipart) cons

InputType::appendFormData(list, multipart);

const AtomicString& dirnameAttrValue = element().fastGetAttribute(dirnameAttr);

if (!dirnameAttrValue.isNull())

- list.appendData(dirnameAttrValue, element().directionForFormData());

+ list.appendData(dirnameAttrValue, element().direction());

return true;

}

« Source/core/html/HTMLElement.cpp ('K') | « Source/core/html/HTMLTextFormControlElement.cpp ('k') | no next file » | no next file with comments »