Source/core/html/HTMLTextAreaElement.cpp - Issue 524593003: Resolve direction correctly when dir attribute is not in a defined state

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLTextAreaElement.cpp

Issue 524593003: Resolve direction correctly when dir attribute is not in a defined state Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Splitting CL into 2 Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLTextAreaElement.cpp

diff --git a/Source/core/html/HTMLTextAreaElement.cpp b/Source/core/html/HTMLTextAreaElement.cpp

index aee74dfd44c484d1eb9d6286225aeba93da99afc..5138e47fa5fd68b7617a8add594a724b9c8e0742 100644

--- a/Source/core/html/HTMLTextAreaElement.cpp

+++ b/Source/core/html/HTMLTextAreaElement.cpp

@@ -212,7 +212,7 @@ bool HTMLTextAreaElement::appendFormData(FormDataList& encoding, bool)

const AtomicString& dirnameAttrValue = fastGetAttribute(dirnameAttr);

if (!dirnameAttrValue.isNull())

- encoding.appendData(dirnameAttrValue, directionForFormData());

+ encoding.appendData(dirnameAttrValue, direction());

return true;

}

« Source/core/html/HTMLElement.cpp ('K') | « Source/core/html/HTMLElement.cpp ('k') | Source/core/html/HTMLTextFormControlElement.h » ('j') | no next file with comments »