Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1134)

Unified Diff: Source/core/html/HTMLTextFormControlElement.cpp

Issue 524593003: Resolve direction correctly when dir attribute is not in a defined state Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix failing test Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLTextFormControlElement.cpp
diff --git a/Source/core/html/HTMLTextFormControlElement.cpp b/Source/core/html/HTMLTextFormControlElement.cpp
index 6abac1ac4eeb154241618352a49ffdf4f5d5b56e..90fbe863c31fb917d2038ed4ccb7b619259cba0f 100644
--- a/Source/core/html/HTMLTextFormControlElement.cpp
+++ b/Source/core/html/HTMLTextFormControlElement.cpp
@@ -699,26 +699,6 @@ HTMLTextFormControlElement* enclosingTextFormControl(Node* container)
return ancestor && isHTMLTextFormControlElement(*ancestor) && container->containingShadowRoot()->type() == ShadowRoot::UserAgentShadowRoot ? toHTMLTextFormControlElement(ancestor) : 0;
}
-String HTMLTextFormControlElement::directionForFormData() const
-{
- for (const HTMLElement* element = this; element; element = Traversal<HTMLElement>::firstAncestor(*element)) {
- const AtomicString& dirAttributeValue = element->fastGetAttribute(dirAttr);
- if (dirAttributeValue.isNull())
- continue;
-
- if (equalIgnoringCase(dirAttributeValue, "rtl") || equalIgnoringCase(dirAttributeValue, "ltr"))
- return dirAttributeValue;
-
- if (equalIgnoringCase(dirAttributeValue, "auto")) {
- bool isAuto;
- TextDirection textDirection = element->directionalityIfhasDirAutoAttribute(isAuto);
- return textDirection == RTL ? "rtl" : "ltr";
- }
- }
-
- return "ltr";
-}
-
HTMLElement* HTMLTextFormControlElement::innerEditorElement() const
{
return toHTMLElement(userAgentShadowRoot()->getElementById(ShadowElementNames::innerEditor()));

Powered by Google App Engine
This is Rietveld 408576698